Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: third_party/WebKit/Source/core/html/forms/StepRange.cpp

Issue 2097313002: Replace ASSERT macros with DCHECK, etc. in core/html/forms/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/forms/StepRange.cpp
diff --git a/third_party/WebKit/Source/core/html/forms/StepRange.cpp b/third_party/WebKit/Source/core/html/forms/StepRange.cpp
index b1769b3ab5607f634185a40da82dd5d07c50b9ff..d3b33d6ba049e5853d1b206b0d2f073954ae2de6 100644
--- a/third_party/WebKit/Source/core/html/forms/StepRange.cpp
+++ b/third_party/WebKit/Source/core/html/forms/StepRange.cpp
@@ -60,10 +60,10 @@ StepRange::StepRange(const Decimal& stepBase, const Decimal& minimum, const Deci
, m_hasStep(step.isFinite())
, m_hasRangeLimitations(hasRangeLimitations)
{
- ASSERT(m_maximum.isFinite());
- ASSERT(m_minimum.isFinite());
- ASSERT(m_step.isFinite());
- ASSERT(m_stepBase.isFinite());
+ DCHECK(m_maximum.isFinite());
+ DCHECK(m_minimum.isFinite());
+ DCHECK(m_step.isFinite());
+ DCHECK(m_stepBase.isFinite());
}
Decimal StepRange::acceptableError() const
@@ -108,7 +108,7 @@ Decimal StepRange::parseStep(AnyStepHandling anyStepHandling, const StepDescript
case AnyIsDefaultStep:
return stepDescription.defaultValue();
default:
- ASSERT_NOT_REACHED();
+ NOTREACHED();
}
}
@@ -131,10 +131,10 @@ Decimal StepRange::parseStep(AnyStepHandling anyStepHandling, const StepDescript
step = std::max(step.round(), Decimal(1));
break;
default:
- ASSERT_NOT_REACHED();
+ NOTREACHED();
}
- ASSERT(step > 0);
+ DCHECK_GT(step, 0);
return step;
}

Powered by Google App Engine
This is Rietveld 408576698