Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: third_party/WebKit/Source/core/html/forms/RangeInputType.cpp

Issue 2097313002: Replace ASSERT macros with DCHECK, etc. in core/html/forms/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/forms/RangeInputType.cpp
diff --git a/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp b/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp
index b5bc8c4737be4ed2d43b556ac29a8c961447af3c..e91b6744e21b01b7d9fde5abab14d158326bc22a 100644
--- a/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp
+++ b/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp
@@ -159,7 +159,7 @@ void RangeInputType::handleMouseDownEvent(MouseEvent* event)
Node* targetNode = event->target()->toNode();
if (event->button() != LeftButton || !targetNode)
return;
- ASSERT(element().shadow());
+ DCHECK(element().shadow());
if (targetNode != element() && !targetNode->isDescendantOf(element().userAgentShadowRoot()))
return;
SliderThumbElement* thumb = sliderThumbElement();
@@ -199,7 +199,7 @@ void RangeInputType::handleKeydownEvent(KeyboardEvent* event)
const String& key = event->key();
const Decimal current = parseToNumberOrNaN(element().value());
- ASSERT(current.isFinite());
+ DCHECK(current.isFinite());
StepRange stepRange(createStepRange(RejectAny));
@@ -253,7 +253,7 @@ void RangeInputType::handleKeydownEvent(KeyboardEvent* event)
void RangeInputType::createShadowSubtree()
{
- ASSERT(element().shadow());
+ DCHECK(element().shadow());
Document& document = element().document();
HTMLDivElement* track = HTMLDivElement::create(document);
@@ -398,7 +398,7 @@ Decimal RangeInputType::findClosestTickMarkValue(const Decimal& value)
size_t right = m_tickMarkValues.size();
size_t middle;
while (true) {
- ASSERT(left <= right);
+ DCHECK_LE(left, right);
middle = left + (right - left) / 2;
if (!middle)
break;

Powered by Google App Engine
This is Rietveld 408576698