Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2093603002: Wrap non-GCed raw pointer parameters of WTF::bind with WTF::unretained (Closed)

Created:
4 years, 6 months ago by tzik
Modified:
4 years, 6 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews-platform-graphics_chromium.org, dshwang, eae+blinkwatch, kinuko+watch, blink-reviews-wtf_chromium.org, rwlbuis, krit, drott+blinkwatch_chromium.org, Justin Novosad, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, gavinp+loader_chromium.org, blink-reviews, ajuma+watch_chromium.org, Mads Ager (chromium), Peter Beverloo, sof, jbroman, loading-reviews_chromium.org, pdr+graphicswatchlist_chromium.org, Nate Chapin, Stephen Chennney, tyoshino+watch_chromium.org, scheduler-bugs_chromium.org, f(malita), oilpan-reviews, danakj+watch_chromium.org, kouhei+heap_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@unretained_wrapper
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Wrap non-GCed raw pointer parameters of WTF::bind with WTF::unretained This CL wraps all raw pointer parameters of WTF::bind with WTF::unretained, as a preparation of raw pointer removal on WTF::bind. BUG=597856 Committed: https://crrev.com/229c0a1fa80fb523ccaffa73c002e601e162ccb9 Cr-Commit-Position: refs/heads/master@{#401604}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -30 lines) Patch
M third_party/WebKit/Source/core/dom/MainThreadTaskRunnerTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/NetworkStateNotifierTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerHandleUtil.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationResourcesLoaderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/worklet/Worklet.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/CancellableTaskFactory.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/CancellableTaskFactoryTest.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
tzik
PTAL
4 years, 6 months ago (2016-06-23 12:50:37 UTC) #3
haraken
LGTM Ideally we want to replace those unretained poniters with wrapPersistent or something. But that's ...
4 years, 6 months ago (2016-06-23 14:15:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2093603002/20001
4 years, 6 months ago (2016-06-23 14:38:15 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-23 14:43:25 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 14:47:38 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/229c0a1fa80fb523ccaffa73c002e601e162ccb9
Cr-Commit-Position: refs/heads/master@{#401604}

Powered by Google App Engine
This is Rietveld 408576698