third_party/WebKit/Source/core/page/NetworkStateNotifierTest.cpp - Issue 2093603002: Wrap non-GCed raw pointer parameters of WTF::bind with WTF::unretained

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/NetworkStateNotifierTest.cpp

Issue 2093603002: Wrap non-GCed raw pointer parameters of WTF::bind with WTF::unretained (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@unretained_wrapper

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp ('k') | third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/NetworkStateNotifierTest.cpp

diff --git a/third_party/WebKit/Source/core/page/NetworkStateNotifierTest.cpp b/third_party/WebKit/Source/core/page/NetworkStateNotifierTest.cpp

index e4c5bdc82e8161e028c755ef796b3b2cb2e32b7f..5d189315bfa22feffefca09df1fa178b13c64388 100644

--- a/third_party/WebKit/Source/core/page/NetworkStateNotifierTest.cpp

+++ b/third_party/WebKit/Source/core/page/NetworkStateNotifierTest.cpp

@@ -119,12 +119,12 @@ protected:

void addObserverOnNotification(StateObserver* observer, StateObserver* observerToAdd)

{

- observer->setNotificationCallback(bind(&NetworkStateNotifier::addObserver, &m_notifier, observerToAdd, wrapPersistent(getExecutionContext())));

+ observer->setNotificationCallback(bind(&NetworkStateNotifier::addObserver, WTF::unretained(&m_notifier), WTF::unretained(observerToAdd), wrapPersistent(getExecutionContext())));

}

void removeObserverOnNotification(StateObserver* observer, StateObserver* observerToRemove)

{

- observer->setNotificationCallback(bind(&NetworkStateNotifier::removeObserver, &m_notifier, observerToRemove, wrapPersistent(getExecutionContext())));

+ observer->setNotificationCallback(bind(&NetworkStateNotifier::removeObserver, WTF::unretained(&m_notifier), WTF::unretained(observerToRemove), wrapPersistent(getExecutionContext())));

}

bool verifyObservations(const StateObserver& observer, WebConnectionType type, double maxBandwidthMbps)