third_party/WebKit/Source/modules/worklet/Worklet.cpp - Issue 2093603002: Wrap non-GCed raw pointer parameters of WTF::bind with WTF::unretained

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/worklet/Worklet.cpp

Issue 2093603002: Wrap non-GCed raw pointer parameters of WTF::bind with WTF::unretained (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@unretained_wrapper

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/notifications/NotificationResourcesLoaderTest.cpp ('k') | third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/worklet/Worklet.cpp

diff --git a/third_party/WebKit/Source/modules/worklet/Worklet.cpp b/third_party/WebKit/Source/modules/worklet/Worklet.cpp

index 49f93e5ec096f4c5dbea9910324898ef402cf5e8..54993701b26d3318a46beafde5caadf43c95419a 100644

--- a/third_party/WebKit/Source/modules/worklet/Worklet.cpp

+++ b/third_party/WebKit/Source/modules/worklet/Worklet.cpp

@@ -42,8 +42,8 @@ ScriptPromise Worklet::import(ScriptState* scriptState, const String& url)

m_scriptLoaders.append(WorkerScriptLoader::create());

m_scriptLoaders.last()->loadAsynchronously(*getExecutionContext(), scriptURL, DenyCrossOriginRequests,

getExecutionContext()->securityContext().addressSpace(),

- bind(&Worklet::onResponse, wrapPersistent(this), m_scriptLoaders.last().get()),

- bind(&Worklet::onFinished, wrapPersistent(this), m_scriptLoaders.last().get(), wrapPersistent(resolver)));

+ bind(&Worklet::onResponse, wrapPersistent(this), WTF::unretained(m_scriptLoaders.last().get())),

+ bind(&Worklet::onFinished, wrapPersistent(this), WTF::unretained(m_scriptLoaders.last().get()), wrapPersistent(resolver)));

return promise;

}