third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h - Issue 2093603002: Wrap non-GCed raw pointer parameters of WTF::bind with WTF::unretained

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h

Issue 2093603002: Wrap non-GCed raw pointer parameters of WTF::bind with WTF::unretained (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@unretained_wrapper

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/page/NetworkStateNotifierTest.cpp ('k') | third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h

diff --git a/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h b/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h

index 9b60dff0f24fa723dabc9a6a905465a8eb4adab2..245025b69271e4fa2f910f727b06ad7d467a7d29 100644

--- a/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h

+++ b/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h

@@ -518,7 +518,7 @@ public:

private:

void start(std::unique_ptr<WebDataConsumerHandle> handle)

{

- m_handleReader = wrapUnique(new T(std::move(handle), WTF::bind(&HandleReaderRunner::onFinished, this)));

+ m_handleReader = wrapUnique(new T(std::move(handle), WTF::bind(&HandleReaderRunner::onFinished, WTF::unretained(this))));

}

void onFinished(std::unique_ptr<HandleReadResult> result)