Update ParamStorageTraits to disallow raw pointers and Member<> (2/5)

Update ParamStorageTraits to disallow raw pointers and Member<>

This CL removes ParamStorageTraits for pointers and add static_assert to
ban raw pointers and Member<>, so that WTF::bind and blink::threadSafeBind
start rejecting them.

BUG=597856
Committed: https://crrev.com/74736be3a74e419cbd88bf36e3855f375b913db5
Cr-Commit-Position: refs/heads/master@{#402113}

[tzik, 2016-06-23 15:03:40]

Description was changed from

==========
Update ParamStorageTraits to disallow raw pointers and Member<>

BUG=
==========

to

==========
Update ParamStorageTraits to disallow raw pointers and Member<>

TODO: PSA to blink-dev.

BUG=
==========

[tzik, 2016-06-23 15:03:41]

tzik@chromium.org changed reviewers:
+ haraken@chromium.org, hiroshige@chromium.org, sigbjornf@opera.com

[tzik, 2016-06-23 15:04:34]

Description was changed from

==========
Update ParamStorageTraits to disallow raw pointers and Member<>

TODO: PSA to blink-dev.

BUG=
==========

to

==========
Update ParamStorageTraits to disallow raw pointers and Member<>

TODO:
 - PSA to blink-dev.
 - Description

BUG=597856
==========

[tzik, 2016-06-24 11:11:28]

Description was changed from

==========
Update ParamStorageTraits to disallow raw pointers and Member<>

TODO:
 - PSA to blink-dev.
 - Description

BUG=597856
==========

to

==========
Update ParamStorageTraits to disallow raw pointers and Member<>

123456789012345678901234567890123456789012345678901234567890123456789012

This CL removes ParamStorageTraits for pointers and add static_assert to
ban raw pointers and Member<>, so that WTF::bind and blink::threadSafeBind
start rejecting them. 

TODO:
 - PSA to blink-dev.

BUG=597856
==========

[tzik, 2016-06-24 11:11:47]

PTAL

[sof, 2016-06-24 11:37:20]

https://codereview.chromium.org/2096623002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/Functional.h (right):

https://codereview.chromium.org/2096623002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/Functional.h:219:
static_assert(!std::is_pointer<T>::value, "Raw pointer is not allowed to bind
into WTF::Function. Wrap it with either Persistent, WeakPersistent,
CrossThreadPersistent, CrossThreadWeakPersistent, RefPtr or unretained.");
Shouldn't the error message be mentioning wrapPersistent() et al?

https://codereview.chromium.org/2096623002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/Functional.h:220:
static_assert(!IsSubclassOfTemplate<T, blink::Member>::value, "Member is not
allowed to bind into WTF::Function. Wrap it with either Persistent,
WeakPersistent, CrossThreadPersistent or CrossThreadWeakPersistenst.");
Add a case for WeakMember<>?

[tzik, 2016-06-24 13:13:33]

https://codereview.chromium.org/2096623002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/Functional.h (right):

https://codereview.chromium.org/2096623002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/Functional.h:219:
static_assert(!std::is_pointer<T>::value, "Raw pointer is not allowed to bind
into WTF::Function. Wrap it with either Persistent, WeakPersistent,
CrossThreadPersistent, CrossThreadWeakPersistent, RefPtr or unretained.");
On 2016/06/24 11:37:19, sof wrote:
> Shouldn't the error message be mentioning wrapPersistent() et al?

OK, replaced them to wrap*.

https://codereview.chromium.org/2096623002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/Functional.h:220:
static_assert(!IsSubclassOfTemplate<T, blink::Member>::value, "Member is not
allowed to bind into WTF::Function. Wrap it with either Persistent,
WeakPersistent, CrossThreadPersistent or CrossThreadWeakPersistenst.");
On 2016/06/24 11:37:19, sof wrote:
> Add a case for WeakMember<>?

Done.

[sof, 2016-06-24 18:47:13]

lgtm

[haraken, 2016-06-24 22:53:09]

LGTM

[tzik, 2016-06-25 02:51:54]

Description was changed from

==========
Update ParamStorageTraits to disallow raw pointers and Member<>

123456789012345678901234567890123456789012345678901234567890123456789012

This CL removes ParamStorageTraits for pointers and add static_assert to
ban raw pointers and Member<>, so that WTF::bind and blink::threadSafeBind
start rejecting them. 

TODO:
 - PSA to blink-dev.

BUG=597856
==========

to

==========
Update ParamStorageTraits to disallow raw pointers and Member<>

This CL removes ParamStorageTraits for pointers and add static_assert to
ban raw pointers and Member<>, so that WTF::bind and blink::threadSafeBind
start rejecting them. 

TODO:
 - PSA to blink-dev.

BUG=597856
==========

[hiroshige, 2016-06-26 08:12:14]

lgtm with a nit.

https://codereview.chromium.org/2096623002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/Functional.h (right):

https://codereview.chromium.org/2096623002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/Functional.h:221:
static_assert(!IsSubclassOfTemplate<T, blink::Member>::value &&
!IsSubclassOfTemplate<T, blink::WeakMember>::value, "Member and WeakMember are
not allowed to bind into WTF::Function. Wrap it with either wrapPersistent,
wrapWeakPersistent, wrapCrossThreadPersistent or
wrapCrossThreadWeakPersistenst.");
nit: s/wrapCrossThreadWeakPersistenst/wrapCrossThreadWeakPersistent/

[tzik, 2016-06-26 19:03:05]

https://codereview.chromium.org/2096623002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/Functional.h (right):

https://codereview.chromium.org/2096623002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/Functional.h:221:
static_assert(!IsSubclassOfTemplate<T, blink::Member>::value &&
!IsSubclassOfTemplate<T, blink::WeakMember>::value, "Member and WeakMember are
not allowed to bind into WTF::Function. Wrap it with either wrapPersistent,
wrapWeakPersistent, wrapCrossThreadPersistent or
wrapCrossThreadWeakPersistenst.");
On 2016/06/26 08:12:14, hiroshige (slow) wrote:
> nit: s/wrapCrossThreadWeakPersistenst/wrapCrossThreadWeakPersistent/

...! Fixed!

[tzik, 2016-06-27 04:18:45]

Description was changed from

==========
Update ParamStorageTraits to disallow raw pointers and Member<>

This CL removes ParamStorageTraits for pointers and add static_assert to
ban raw pointers and Member<>, so that WTF::bind and blink::threadSafeBind
start rejecting them. 

TODO:
 - PSA to blink-dev.

BUG=597856
==========

to

==========
Update ParamStorageTraits to disallow raw pointers and Member<>

This CL removes ParamStorageTraits for pointers and add static_assert to
ban raw pointers and Member<>, so that WTF::bind and blink::threadSafeBind
start rejecting them. 

BUG=597856
==========

[tzik, 2016-06-27 04:19:38]

The CQ bit was checked by tzik@chromium.org

[tzik, 2016-06-27 04:19:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, hiroshige@chromium.org, sigbjornf@opera.com
Link to the patchset: https://codereview.chromium.org/2096623002/#ps80001
(title: "typo fix")

[commit-bot: I haz the power, 2016-06-27 04:19:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 04:58:50]

Description was changed from

==========
Update ParamStorageTraits to disallow raw pointers and Member<>

This CL removes ParamStorageTraits for pointers and add static_assert to
ban raw pointers and Member<>, so that WTF::bind and blink::threadSafeBind
start rejecting them. 

BUG=597856
==========

to

==========
Update ParamStorageTraits to disallow raw pointers and Member<>

This CL removes ParamStorageTraits for pointers and add static_assert to
ban raw pointers and Member<>, so that WTF::bind and blink::threadSafeBind
start rejecting them. 

BUG=597856
==========

[commit-bot: I haz the power, 2016-06-27 04:58:51]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-27 05:00:42]

Description was changed from

==========
Update ParamStorageTraits to disallow raw pointers and Member<>

This CL removes ParamStorageTraits for pointers and add static_assert to
ban raw pointers and Member<>, so that WTF::bind and blink::threadSafeBind
start rejecting them. 

BUG=597856
==========

to

==========
Update ParamStorageTraits to disallow raw pointers and Member<>

This CL removes ParamStorageTraits for pointers and add static_assert to
ban raw pointers and Member<>, so that WTF::bind and blink::threadSafeBind
start rejecting them.

BUG=597856

Committed: https://crrev.com/74736be3a74e419cbd88bf36e3855f375b913db5
Cr-Commit-Position: refs/heads/master@{#402113}
==========

[commit-bot: I haz the power, 2016-06-27 05:00:43]

Patchset 5 (id:??) landed as
https://crrev.com/74736be3a74e419cbd88bf36e3855f375b913db5
Cr-Commit-Position: refs/heads/master@{#402113}