third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp - Issue 2093603002: Wrap non-GCed raw pointer parameters of WTF::bind with WTF::unretained

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp

Issue 2093603002: Wrap non-GCed raw pointer parameters of WTF::bind with WTF::unretained (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@unretained_wrapper

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp ('k') | third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp b/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp

index e8101a336b3389eab840976c97055aed9ce970a2..d99dfb18f783f68671c33971ec8ea7dff92a5402 100644

--- a/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp

+++ b/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp

@@ -181,8 +181,8 @@ void WebSharedWorkerImpl::didFinishDocumentLoad(WebLocalFrame* frame)

m_url,

DenyCrossOriginRequests,

m_creationAddressSpace,

- bind(&WebSharedWorkerImpl::didReceiveScriptLoaderResponse, this),

- bind(&WebSharedWorkerImpl::onScriptLoaderFinished, this));

+ bind(&WebSharedWorkerImpl::didReceiveScriptLoaderResponse, WTF::unretained(this)),

+ bind(&WebSharedWorkerImpl::onScriptLoaderFinished, WTF::unretained(this)));

// Do nothing here since onScriptLoaderFinished() might have been already

// invoked and |this| might have been deleted at this point.

}