third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp - Issue 2093603002: Wrap non-GCed raw pointer parameters of WTF::bind with WTF::unretained

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp

Issue 2093603002: Wrap non-GCed raw pointer parameters of WTF::bind with WTF::unretained (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@unretained_wrapper

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/worklet/Worklet.cpp ('k') | third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp b/third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp

index 60c6f76b6ecff1f614f478bf112befa82bdecfce..e94427b7473a050d38dd14fb47679e8f325caa67 100644

--- a/third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp

+++ b/third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp

@@ -33,8 +33,8 @@ bool CanvasSurfaceLayerBridge::createSurfaceLayer(int canvasWidth, int canvasHei

return false;

m_client->asyncRequestSurfaceCreation(m_surfaceId);

- cc::SurfaceLayer::SatisfyCallback satisfyCallback = createBaseCallback(bind(&CanvasSurfaceLayerBridge::satisfyCallback, this));

- cc::SurfaceLayer::RequireCallback requireCallback = createBaseCallback(bind(&CanvasSurfaceLayerBridge::requireCallback, this));

+ cc::SurfaceLayer::SatisfyCallback satisfyCallback = createBaseCallback(bind(&CanvasSurfaceLayerBridge::satisfyCallback, WTF::unretained(this)));

+ cc::SurfaceLayer::RequireCallback requireCallback = createBaseCallback(bind(&CanvasSurfaceLayerBridge::requireCallback, WTF::unretained(this)));

m_surfaceLayer = cc::SurfaceLayer::Create(std::move(satisfyCallback), std::move(requireCallback));

m_surfaceLayer->SetSurfaceId(m_surfaceId, 1.f, gfx::Size(canvasWidth, canvasHeight));