🎅 Use GN's dependency info for native libraries in write_build_config.py

Use GN's dependency info for native libraries in write_build_config.py

This is in place of readelf / write_ordered_libaries.py.

Main motivation is to be able to write .build_config files quickly, so
that they can be used for generating build.gradle files for Android
Studio without first needing to build a bunch of native libraries.

BUG=620034
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/48bd27ea3fd3b86e352d6a7a8e4e70b0c711ae78
Cr-Commit-Position: refs/heads/master@{#401398}

[agrieve, 2016-06-20 20:39:28]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-20 20:39:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2082453003/1

[commit-bot: I haz the power, 2016-06-20 21:00:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 21:00:46]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[agrieve, 2016-06-21 02:16:37]

Description was changed from

==========
Use GN's dependency info for native libraries in write_build_config.py

This is in place of readelf / write_ordered_libaries.py.

Main motivation is to be able to write .build_config files quickly, so
that they can be used for generating build.gradle files for Android
Studio without first needing to build a bunch of native libraries.

BUG=620034
==========

to

==========
Use GN's dependency info for native libraries in write_build_config.py

This is in place of readelf / write_ordered_libaries.py.

Main motivation is to be able to write .build_config files quickly, so
that they can be used for generating build.gradle files for Android
Studio without first needing to build a bunch of native libraries.

BUG=620034
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[agrieve, 2016-06-21 02:16:49]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-21 02:17:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2082453003/20001

[commit-bot: I haz the power, 2016-06-21 02:50:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-21 02:50:02]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[agrieve, 2016-06-21 16:57:36]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-21 16:58:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2082453003/20001

[agrieve, 2016-06-21 17:05:33]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[agrieve, 2016-06-21 17:05:57]

Description was changed from

==========
Use GN's dependency info for native libraries in write_build_config.py

This is in place of readelf / write_ordered_libaries.py.

Main motivation is to be able to write .build_config files quickly, so
that they can be used for generating build.gradle files for Android
Studio without first needing to build a bunch of native libraries.

BUG=620034
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Use GN's dependency info for native libraries in write_build_config.py

This is in place of readelf / write_ordered_libaries.py.

Main motivation is to be able to write .build_config files quickly, so
that they can be used for generating build.gradle files for Android
Studio without first needing to build a bunch of native libraries.

BUG=620034
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[agrieve, 2016-06-21 17:05:57]

agrieve@chromium.org changed reviewers:
+ brettw@chromium.org, jbudorick@chromium.org

[commit-bot: I haz the power, 2016-06-21 17:06:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2082453003/60001

[agrieve, 2016-06-21 17:07:22]

On 2016/06/21 16:58:00, commit-bot: I haz the power wrote:
> Dry run: CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/2082453003/20001

jbudorick - please do main review of build/*
brettw - please review all .gn file changes (and also peek at how I'm using
write_runtime_deps for this).

[commit-bot: I haz the power, 2016-06-21 18:26:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-21 18:26:01]

Dry run: This issue passed the CQ dry run.

[jbudorick, 2016-06-22 14:20:48]

This looks like it'll break gyp again. We should make sure those webrtc bots
have moved before landing.

https://codereview.chromium.org/2082453003/diff/60001/build/android/gyp/write...
File build/android/gyp/write_build_config.py (left):

https://codereview.chromium.org/2082453003/diff/60001/build/android/gyp/write...
build/android/gyp/write_build_config.py:540:
write_ordered_libraries.SetReadelfPath(options.readelf_path)
Do we no longer need to do the library ordering logic here? If not, can we
either remove that code entirely or at least nix the import here?

https://codereview.chromium.org/2082453003/diff/60001/build/config/android/ru...
File build/config/android/rules.gni (left):

https://codereview.chromium.org/2082453003/diff/60001/build/config/android/ru...
build/config/android/rules.gni:1403: #     The extension is automatically
changed to ".cr.so".
Is this no longer true?

https://codereview.chromium.org/2082453003/diff/60001/build/config/android/ru...
File build/config/android/rules.gni (right):

https://codereview.chromium.org/2082453003/diff/60001/build/config/android/ru...
build/config/android/rules.gni:1548: deps = _native_libs_deps
Does this need to be a build-time dependency? Could it instead be data_deps,
allowing the build_config target to depend on the runtime_deps target w/o
requiring the native libs to be built beforehand?

[agrieve, 2016-06-22 14:34:00]

This shouldn't break GYP since GYP doesn't use write_build_config.py

https://codereview.chromium.org/2082453003/diff/60001/build/android/gyp/write...
File build/android/gyp/write_build_config.py (left):

https://codereview.chromium.org/2082453003/diff/60001/build/android/gyp/write...
build/android/gyp/write_build_config.py:540:
write_ordered_libraries.SetReadelfPath(options.readelf_path)
On 2016/06/22 14:20:48, jbudorick (EMEA til June 30) wrote:
> Do we no longer need to do the library ordering logic here? If not, can we
> either remove that code entirely or at least nix the import here?

It seems GN is consistent in ordering the files in dependency order.

GYP doesn't use write_build_config, but it does still use
write_ordered_libraries. I think we can't delete the code until GYP is gone.

https://codereview.chromium.org/2082453003/diff/60001/build/config/android/ru...
File build/config/android/rules.gni (left):

https://codereview.chromium.org/2082453003/diff/60001/build/config/android/ru...
build/config/android/rules.gni:1403: #     The extension is automatically
changed to ".cr.so".
On 2016/06/22 14:20:48, jbudorick (EMEA til June 30) wrote:
> Is this no longer true?

We're now specifying target labels rather than file names, so the comment isn't
really relevant anymore (but it does still output the correct names when in
component mode)

https://codereview.chromium.org/2082453003/diff/60001/build/config/android/ru...
File build/config/android/rules.gni (right):

https://codereview.chromium.org/2082453003/diff/60001/build/config/android/ru...
build/config/android/rules.gni:1548: deps = _native_libs_deps
On 2016/06/22 14:20:48, jbudorick (EMEA til June 30) wrote:
> Does this need to be a build-time dependency? Could it instead be data_deps,
> allowing the build_config target to depend on the runtime_deps target w/o
> requiring the native libs to be built beforehand?

My goal is to write a script that will directly build all __build_config
targets, and not have to wait for all of the native code to build. This could
use data_deps, but then ninja wouldn't return until all of them have built.

[jbudorick, 2016-06-22 14:52:52]

I obviously forgot that gyp doesn't use write_build_config.

https://codereview.chromium.org/2082453003/diff/60001/build/android/gyp/write...
File build/android/gyp/write_build_config.py (left):

https://codereview.chromium.org/2082453003/diff/60001/build/android/gyp/write...
build/android/gyp/write_build_config.py:540:
write_ordered_libraries.SetReadelfPath(options.readelf_path)
On 2016/06/22 14:33:59, agrieve wrote:
> On 2016/06/22 14:20:48, jbudorick (EMEA til June 30) wrote:
> > Do we no longer need to do the library ordering logic here? If not, can we
> > either remove that code entirely or at least nix the import here?
> 
> It seems GN is consistent in ordering the files in dependency order.
> 
> GYP doesn't use write_build_config, but it does still use
> write_ordered_libraries. I think we can't delete the code until GYP is gone.

sgtm

https://codereview.chromium.org/2082453003/diff/60001/build/android/gyp/write...
File build/android/gyp/write_build_config.py (right):

https://codereview.chromium.org/2082453003/diff/60001/build/android/gyp/write...
build/android/gyp/write_build_config.py:38: import write_ordered_libraries
nit: get rid of this

https://codereview.chromium.org/2082453003/diff/60001/build/config/android/ru...
File build/config/android/rules.gni (right):

https://codereview.chromium.org/2082453003/diff/60001/build/config/android/ru...
build/config/android/rules.gni:1548: deps = _native_libs_deps
On 2016/06/22 14:33:59, agrieve wrote:
> On 2016/06/22 14:20:48, jbudorick (EMEA til June 30) wrote:
> > Does this need to be a build-time dependency? Could it instead be data_deps,
> > allowing the build_config target to depend on the runtime_deps target w/o
> > requiring the native libs to be built beforehand?
> 
> My goal is to write a script that will directly build all __build_config
> targets, and not have to wait for all of the native code to build. This could
> use data_deps, but then ninja wouldn't return until all of them have built.

Ah, ok. So it wants to depend on the names but not the actual objects?

[agrieve, 2016-06-22 15:39:24]

https://codereview.chromium.org/2082453003/diff/60001/build/android/gyp/write...
File build/android/gyp/write_build_config.py (right):

https://codereview.chromium.org/2082453003/diff/60001/build/android/gyp/write...
build/android/gyp/write_build_config.py:38: import write_ordered_libraries
On 2016/06/22 14:52:52, jbudorick (EMEA til June 30) wrote:
> nit: get rid of this

Done.

https://codereview.chromium.org/2082453003/diff/60001/build/config/android/ru...
File build/config/android/rules.gni (right):

https://codereview.chromium.org/2082453003/diff/60001/build/config/android/ru...
build/config/android/rules.gni:1548: deps = _native_libs_deps
On 2016/06/22 14:52:52, jbudorick (EMEA til June 30) wrote:
> On 2016/06/22 14:33:59, agrieve wrote:
> > On 2016/06/22 14:20:48, jbudorick (EMEA til June 30) wrote:
> > > Does this need to be a build-time dependency? Could it instead be
data_deps,
> > > allowing the build_config target to depend on the runtime_deps target w/o
> > > requiring the native libs to be built beforehand?
> > 
> > My goal is to write a script that will directly build all __build_config
> > targets, and not have to wait for all of the native code to build. This
could
> > use data_deps, but then ninja wouldn't return until all of them have built.
> 
> Ah, ok. So it wants to depend on the names but not the actual objects?

Exactly. It just needs the output paths, but they don't need to exist yet.

[jbudorick, 2016-06-22 15:44:22]

lgtm

https://codereview.chromium.org/2082453003/diff/60001/build/config/android/ru...
File build/config/android/rules.gni (right):

https://codereview.chromium.org/2082453003/diff/60001/build/config/android/ru...
build/config/android/rules.gni:1548: deps = _native_libs_deps
On 2016/06/22 15:39:23, agrieve wrote:
> On 2016/06/22 14:52:52, jbudorick (EMEA til June 30) wrote:
> > On 2016/06/22 14:33:59, agrieve wrote:
> > > On 2016/06/22 14:20:48, jbudorick (EMEA til June 30) wrote:
> > > > Does this need to be a build-time dependency? Could it instead be
> data_deps,
> > > > allowing the build_config target to depend on the runtime_deps target
w/o
> > > > requiring the native libs to be built beforehand?
> > > 
> > > My goal is to write a script that will directly build all __build_config
> > > targets, and not have to wait for all of the native code to build. This
> could
> > > use data_deps, but then ninja wouldn't return until all of them have
built.
> > 
> > Ah, ok. So it wants to depend on the names but not the actual objects?
> 
> Exactly. It just needs the output paths, but they don't need to exist yet.

sgtm

[brettw, 2016-06-22 18:03:01]

lgtm

[agrieve, 2016-06-22 18:15:35]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-06-22 18:15:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org, brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2082453003/#ps100001
(title: "remove dependent patchset (ugh)")

[commit-bot: I haz the power, 2016-06-22 18:15:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2082453003/100001

[commit-bot: I haz the power, 2016-06-22 21:04:26]

Description was changed from

==========
Use GN's dependency info for native libraries in write_build_config.py

This is in place of readelf / write_ordered_libaries.py.

Main motivation is to be able to write .build_config files quickly, so
that they can be used for generating build.gradle files for Android
Studio without first needing to build a bunch of native libraries.

BUG=620034
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Use GN's dependency info for native libraries in write_build_config.py

This is in place of readelf / write_ordered_libaries.py.

Main motivation is to be able to write .build_config files quickly, so
that they can be used for generating build.gradle files for Android
Studio without first needing to build a bunch of native libraries.

BUG=620034
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-06-22 21:04:28]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-22 21:09:24]

Description was changed from

==========
Use GN's dependency info for native libraries in write_build_config.py

This is in place of readelf / write_ordered_libaries.py.

Main motivation is to be able to write .build_config files quickly, so
that they can be used for generating build.gradle files for Android
Studio without first needing to build a bunch of native libraries.

BUG=620034
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Use GN's dependency info for native libraries in write_build_config.py

This is in place of readelf / write_ordered_libaries.py.

Main motivation is to be able to write .build_config files quickly, so
that they can be used for generating build.gradle files for Android
Studio without first needing to build a bunch of native libraries.

BUG=620034
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/48bd27ea3fd3b86e352d6a7a8e4e70b0c711ae78
Cr-Commit-Position: refs/heads/master@{#401398}
==========

[commit-bot: I haz the power, 2016-06-22 21:09:26]

Patchset 6 (id:??) landed as
https://crrev.com/48bd27ea3fd3b86e352d6a7a8e4e70b0c711ae78
Cr-Commit-Position: refs/heads/master@{#401398}