Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2490)

Unified Diff: content/shell/android/BUILD.gn

Issue 2082453003: 🎅 Use GN's dependency info for native libraries in write_build_config.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove dependent patchset (ugh) Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/android/BUILD.gn ('k') | mojo/android/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/android/BUILD.gn
diff --git a/content/shell/android/BUILD.gn b/content/shell/android/BUILD.gn
index 38afc3ca705255d5e35995bcd3ad8f424f0bdd19..0d23dd20e586147cfadbafe1df0c46e55dd3986b 100644
--- a/content/shell/android/BUILD.gn
+++ b/content/shell/android/BUILD.gn
@@ -114,7 +114,6 @@ android_apk("content_shell_apk") {
":content_shell_assets",
":content_shell_java",
":content_shell_manifest",
- ":libcontent_shell_content_view",
"//base:base_java",
"//content/public/android:content_java",
"//content/public/test/android:layouttest_java_support",
@@ -125,7 +124,7 @@ android_apk("content_shell_apk") {
]
apk_name = "ContentShell"
android_manifest = content_shell_manifest
- native_libs = [ "libcontent_shell_content_view.so" ]
+ shared_libraries = [ ":libcontent_shell_content_view" ]
loadable_modules = [ "$root_out_dir/libosmesa.so" ]
}
@@ -190,7 +189,6 @@ if (current_cpu != "x64") {
":content_shell_assets",
":content_shell_java",
":linker_resources",
- ":linker_test",
"//base:base_java",
"//content/public/android:content_java",
"//ui/android:ui_java",
@@ -202,7 +200,7 @@ if (current_cpu != "x64") {
"linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java",
"linker_test_apk/src/org/chromium/chromium_linker_test_apk/LinkerTests.java",
]
- native_libs = [ "liblinker_test.so" ]
+ shared_libraries = [ ":linker_test" ]
use_chromium_linker = true
enable_chromium_linker_tests = true
}
« no previous file with comments | « components/cronet/android/BUILD.gn ('k') | mojo/android/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698