Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: chrome/android/BUILD.gn

Issue 2082453003: 🎅 Use GN's dependency info for native libraries in write_build_config.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove dependent patchset (ugh) Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/BUILD.gn ('k') | components/cronet/android/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/BUILD.gn
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
index d92c67a0ae966b2032b57c690ee9c92379d02ccf..74fb4be245540889122aedd65509094c56c0ac1e 100644
--- a/chrome/android/BUILD.gn
+++ b/chrome/android/BUILD.gn
@@ -495,10 +495,9 @@ chrome_public_apk_tmpl_shared("chrome_public_apk") {
android_manifest = get_target_outputs(":chrome_public_apk_manifest")
android_manifest = android_manifest[1]
apk_name = "ChromePublic"
- native_libs = [ "libchrome.so" ]
+ shared_libraries = [ ":chrome" ]
deps = [
- ":chrome",
":chrome_public_apk_manifest",
":chrome_public_apk_template_resources",
]
@@ -509,10 +508,9 @@ chrome_public_apk_tmpl_shared("chrome_sync_shell_apk") {
android_manifest = get_target_outputs(":chrome_sync_shell_apk_manifest")
android_manifest = android_manifest[1]
apk_name = "ChromeSyncShell"
- native_libs = [ "libchrome_sync_shell.so" ]
+ shared_libraries = [ ":chrome_sync_shell" ]
deps = [
- ":chrome_sync_shell",
":chrome_sync_shell_apk_manifest",
":chrome_sync_shell_apk_template_resources",
« no previous file with comments | « cc/BUILD.gn ('k') | components/cronet/android/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698