Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: components/cronet/android/BUILD.gn

Issue 2082453003: 🎅 Use GN's dependency info for native libraries in write_build_config.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove dependent patchset (ugh) Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/BUILD.gn ('k') | content/shell/android/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/BUILD.gn
diff --git a/components/cronet/android/BUILD.gn b/components/cronet/android/BUILD.gn
index b0081287c36d8763dcff781da3be9c0c1c612838..4de7ffb5981f71af0bbd5fb1ecac1bdb1f9659b3 100644
--- a/components/cronet/android/BUILD.gn
+++ b/components/cronet/android/BUILD.gn
@@ -330,10 +330,9 @@ android_library("cronet_sample_apk_java") {
android_apk("cronet_sample_apk") {
apk_name = "CronetSample"
android_manifest = "sample/AndroidManifest.xml"
- native_libs = [ "libcronet.so" ]
+ shared_libraries = [ ":cronet" ]
deps = [
- ":cronet",
":cronet_sample_apk_java",
":cronet_sample_apk_resources",
"//base:base_java",
@@ -533,14 +532,13 @@ android_apk("cronet_test_apk") {
testonly = true
apk_name = "CronetTest"
android_manifest = "test/AndroidManifest.xml"
- native_libs = [ "libcronet_tests.so" ]
+ shared_libraries = [ ":cronet_tests" ]
loadable_modules = [ "$root_out_dir/libnetty-tcnative.so" ]
deps = [
":cronet_test_apk_assets",
":cronet_test_apk_java",
":cronet_test_apk_resources",
- ":cronet_tests",
"//base:base_java",
"//third_party/netty-tcnative:netty-tcnative_all",
]
@@ -652,12 +650,11 @@ android_apk("cronet_perf_test_apk") {
testonly = true
apk_name = "CronetPerfTest"
android_manifest = "test/javaperftests/AndroidManifest.xml"
- native_libs = [ "libcronet_tests.so" ]
+ shared_libraries = [ ":cronet_tests" ]
deps = [
":cronet_perf_test_apk_java",
":cronet_test_apk_java",
- ":cronet_tests",
"//base:base_java",
]
« no previous file with comments | « chrome/android/BUILD.gn ('k') | content/shell/android/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698