blimp/client/BUILD.gn - Issue 2082453003: 🎅 Use GN's dependency info for native libraries in write_build_config.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/BUILD.gn

Issue 2082453003: 🎅 Use GN's dependency info for native libraries in write_build_config.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove dependent patchset (ugh) Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: blimp/client/BUILD.gn

diff --git a/blimp/client/BUILD.gn b/blimp/client/BUILD.gn

index 023f39951db971208f528dea42601c01b9d1b145..15405b34c2cb827e0b1cd0691782471c0b0980f4 100644

--- a/blimp/client/BUILD.gn

+++ b/blimp/client/BUILD.gn

@@ -517,7 +517,6 @@ if (is_android) {

android_apk("blimp_apk") {

deps = [

":blimp_apk_manifest",

- ":blimp_client_android",

":blimp_java",

"//base:base_java",

"//blimp/client/core:core_java",

@@ -526,7 +525,7 @@ if (is_android) {

]

apk_name = "Blimp"

android_manifest = blimp_apk_manifest

- native_libs = [ "libblimp_client_android.so" ]

+ shared_libraries = [ ":blimp_client_android" ]

}

instrumentation_test_apk("blimp_test_apk") {

« no previous file with comments | « android_webview/test/BUILD.gn ('k') | build/android/BUILD.gn » ('j') | no next file with comments »