Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Unified Diff: testing/test.gni

Issue 2082453003: 🎅 Use GN's dependency info for native libraries in write_build_config.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove dependent patchset (ugh) Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/android/remoting_apk_tmpl.gni ('k') | tools/android/memconsumer/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/test.gni
diff --git a/testing/test.gni b/testing/test.gni
index d7aa7cf96b3e9eb62cab9f55103b194cd4511d93..b93ef87756187ee87e737a9602c4578a9aedeb25 100644
--- a/testing/test.gni
+++ b/testing/test.gni
@@ -187,14 +187,12 @@ template("test") {
}
unittest_apk(_apk_target) {
forward_variables_from(invoker, _apk_specific_vars + [ "deps" ])
- unittests_dep = ":$_library_target"
+ shared_library = ":$_library_target"
apk_name = invoker.target_name
if (defined(invoker.output_name)) {
apk_name = invoker.output_name
- unittests_binary = "lib${apk_name}.so"
install_script_name = "install_${invoker.output_name}"
}
- deps += [ ":$_library_target" ]
# TODO(agrieve): Remove this data_dep once bots don't build the _apk
# target (post-GYP).
« no previous file with comments | « remoting/android/remoting_apk_tmpl.gni ('k') | tools/android/memconsumer/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698