remoting/android/BUILD.gn - Issue 2082453003: 🎅 Use GN's dependency info for native libraries in write_build_config.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/android/BUILD.gn

Issue 2082453003: 🎅 Use GN's dependency info for native libraries in write_build_config.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove dependent patchset (ugh) Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/android/BUILD.gn

diff --git a/remoting/android/BUILD.gn b/remoting/android/BUILD.gn

index a3d5ace0a202670e0515a4cfae6269b724f4baf4..17021e30bad4a51ed30ee6580d8a145e9a29419d 100644

--- a/remoting/android/BUILD.gn

+++ b/remoting/android/BUILD.gn

@@ -194,7 +194,7 @@ android_resources("remoting_host_apk_resources") {

android_apk("remoting_host_apk") {

apk_name = "ChromotingHost"

android_manifest = "host/AndroidManifest.xml"

- native_libs = [ "libremoting_host_jni.so" ]

+ shared_libraries = [ ":remoting_host_jni" ]

_java_file_prefix = "host/src/org/chromium/chromoting/host"

_java_files = [

"MainActivity.java",

@@ -207,7 +207,6 @@ android_apk("remoting_host_apk") {

[ "java/src/org/chromium/chromoting/base/OAuthTokenFetcher.java" ]

deps = [

":remoting_host_apk_resources",

- ":remoting_host_jni",

"//base:base_java",

"//net/android:net_java",

"//third_party/android_tools:android_support_v13_java",

« no previous file with comments | « net/android/BUILD.gn ('k') | remoting/android/remoting_apk_tmpl.gni » ('j') | no next file with comments »