Simplify AssemblerPositionsRecorder.

Simplify AssemblerPositionsRecorder.

R=bmeurer@chromium.org, jgruber@chromium.org

Committed: https://crrev.com/9c3d730d424b170080186bb3e924ead6c46b0bcd
Cr-Commit-Position: refs/heads/master@{#37089}

[Yang, 2016-06-17 12:36:49]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-17 12:36:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2072963003/1

[Yang, 2016-06-17 13:03:28]

Please take a look. This removes some historical baggage.

[commit-bot: I haz the power, 2016-06-17 13:05:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 13:05:22]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-06-17 17:38:52]

lgtm

https://codereview.chromium.org/2072963003/diff/1/src/assembler.cc
File src/assembler.cc (right):

https://codereview.chromium.org/2072963003/diff/1/src/assembler.cc#newcode1795
src/assembler.cc:1795: return WriteRecordedPositions();
Nit: We could possibly 'return RecordPosition(pos);' here to avoid duplication.

https://codereview.chromium.org/2072963003/diff/1/src/assembler.h
File src/assembler.h (right):

https://codereview.chromium.org/2072963003/diff/1/src/assembler.h#newcode1147
src/assembler.h:1147: struct PositionState {
Can this be removed?

[Yang, 2016-06-20 06:54:51]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-20 06:54:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2072963003/20001

[Benedikt Meurer, 2016-06-20 06:55:12]

LGTM on crankshaft/compiler

[commit-bot: I haz the power, 2016-06-20 07:21:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 07:21:32]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-06-20 07:27:20]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-06-20 07:27:21]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2072963003/#ps20001
(title: "addressed comment")

[commit-bot: I haz the power, 2016-06-20 07:27:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2072963003/20001

[commit-bot: I haz the power, 2016-06-20 07:30:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-20 07:31:04]

Description was changed from

==========
Simplify AssemblerPositionsRecorder.

R=bmeurer@chromium.org, jgruber@chromium.org
==========

to

==========
Simplify AssemblerPositionsRecorder.

R=bmeurer@chromium.org, jgruber@chromium.org

Committed: https://crrev.com/9c3d730d424b170080186bb3e924ead6c46b0bcd
Cr-Commit-Position: refs/heads/master@{#37089}
==========

[commit-bot: I haz the power, 2016-06-20 07:31:05]

Patchset 2 (id:??) landed as
https://crrev.com/9c3d730d424b170080186bb3e924ead6c46b0bcd
Cr-Commit-Position: refs/heads/master@{#37089}