src/crankshaft/x64/lithium-codegen-x64.cc - Issue 2072963003: Simplify AssemblerPositionsRecorder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/x64/lithium-codegen-x64.cc

Issue 2072963003: Simplify AssemblerPositionsRecorder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: addressed comment Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/x64/lithium-codegen-x64.cc

diff --git a/src/crankshaft/x64/lithium-codegen-x64.cc b/src/crankshaft/x64/lithium-codegen-x64.cc

index 901e928c59e7a62116a485f3970d85ffe168cb77..23d80032277674a3f588122bf23f30e3ae31a767 100644

--- a/src/crankshaft/x64/lithium-codegen-x64.cc

+++ b/src/crankshaft/x64/lithium-codegen-x64.cc

@@ -838,7 +838,6 @@ void LCodeGen::RecordSafepointWithRegisters(LPointerMap* pointers,

void LCodeGen::RecordAndWritePosition(int position) {

if (position == RelocInfo::kNoPosition) return;

masm()->positions_recorder()->RecordPosition(position);

- masm()->positions_recorder()->WriteRecordedPositions();

}