Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Side by Side Diff: src/crankshaft/arm64/lithium-codegen-arm64.cc

Issue 2072963003: Simplify AssemblerPositionsRecorder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: addressed comment Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/arm/lithium-codegen-arm.cc ('k') | src/crankshaft/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/arm64/lithium-codegen-arm64.h" 5 #include "src/crankshaft/arm64/lithium-codegen-arm64.h"
6 6
7 #include "src/arm64/frames-arm64.h" 7 #include "src/arm64/frames-arm64.h"
8 #include "src/base/bits.h" 8 #include "src/base/bits.h"
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 430 matching lines...) Expand 10 before | Expand all | Expand 10 after
441 LoadContextFromDeferred(context); 441 LoadContextFromDeferred(context);
442 __ CallRuntimeSaveDoubles(id); 442 __ CallRuntimeSaveDoubles(id);
443 RecordSafepointWithRegisters( 443 RecordSafepointWithRegisters(
444 instr->pointer_map(), argc, Safepoint::kNoLazyDeopt); 444 instr->pointer_map(), argc, Safepoint::kNoLazyDeopt);
445 } 445 }
446 446
447 447
448 void LCodeGen::RecordAndWritePosition(int position) { 448 void LCodeGen::RecordAndWritePosition(int position) {
449 if (position == RelocInfo::kNoPosition) return; 449 if (position == RelocInfo::kNoPosition) return;
450 masm()->positions_recorder()->RecordPosition(position); 450 masm()->positions_recorder()->RecordPosition(position);
451 masm()->positions_recorder()->WriteRecordedPositions();
452 } 451 }
453 452
454 453
455 void LCodeGen::RecordSafepointWithLazyDeopt(LInstruction* instr, 454 void LCodeGen::RecordSafepointWithLazyDeopt(LInstruction* instr,
456 SafepointMode safepoint_mode) { 455 SafepointMode safepoint_mode) {
457 if (safepoint_mode == RECORD_SIMPLE_SAFEPOINT) { 456 if (safepoint_mode == RECORD_SIMPLE_SAFEPOINT) {
458 RecordSafepoint(instr->pointer_map(), Safepoint::kLazyDeopt); 457 RecordSafepoint(instr->pointer_map(), Safepoint::kLazyDeopt);
459 } else { 458 } else {
460 DCHECK(safepoint_mode == RECORD_SAFEPOINT_WITH_REGISTERS_AND_NO_ARGUMENTS); 459 DCHECK(safepoint_mode == RECORD_SAFEPOINT_WITH_REGISTERS_AND_NO_ARGUMENTS);
461 RecordSafepointWithRegisters( 460 RecordSafepointWithRegisters(
(...skipping 5271 matching lines...) Expand 10 before | Expand all | Expand 10 after
5733 // Index is equal to negated out of object property index plus 1. 5732 // Index is equal to negated out of object property index plus 1.
5734 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2)); 5733 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2));
5735 __ Ldr(result, FieldMemOperand(result, 5734 __ Ldr(result, FieldMemOperand(result,
5736 FixedArray::kHeaderSize - kPointerSize)); 5735 FixedArray::kHeaderSize - kPointerSize));
5737 __ Bind(deferred->exit()); 5736 __ Bind(deferred->exit());
5738 __ Bind(&done); 5737 __ Bind(&done);
5739 } 5738 }
5740 5739
5741 } // namespace internal 5740 } // namespace internal
5742 } // namespace v8 5741 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/arm/lithium-codegen-arm.cc ('k') | src/crankshaft/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698