Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Side by Side Diff: src/mips64/macro-assembler-mips64.cc

Issue 2072963003: Simplify AssemblerPositionsRecorder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: addressed comment Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips64/assembler-mips64.cc ('k') | src/ppc/assembler-ppc.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <limits.h> // For LONG_MIN, LONG_MAX. 5 #include <limits.h> // For LONG_MIN, LONG_MAX.
6 6
7 #if V8_TARGET_ARCH_MIPS64 7 #if V8_TARGET_ARCH_MIPS64
8 8
9 #include "src/base/division-by-constant.h" 9 #include "src/base/division-by-constant.h"
10 #include "src/bootstrapper.h" 10 #include "src/bootstrapper.h"
(...skipping 4013 matching lines...) Expand 10 before | Expand all | Expand 10 after
4024 void MacroAssembler::Call(Address target, 4024 void MacroAssembler::Call(Address target,
4025 RelocInfo::Mode rmode, 4025 RelocInfo::Mode rmode,
4026 Condition cond, 4026 Condition cond,
4027 Register rs, 4027 Register rs,
4028 const Operand& rt, 4028 const Operand& rt,
4029 BranchDelaySlot bd) { 4029 BranchDelaySlot bd) {
4030 BlockTrampolinePoolScope block_trampoline_pool(this); 4030 BlockTrampolinePoolScope block_trampoline_pool(this);
4031 Label start; 4031 Label start;
4032 bind(&start); 4032 bind(&start);
4033 int64_t target_int = reinterpret_cast<int64_t>(target); 4033 int64_t target_int = reinterpret_cast<int64_t>(target);
4034 // Must record previous source positions before the
4035 // li() generates a new code target.
4036 positions_recorder()->WriteRecordedPositions();
4037 li(t9, Operand(target_int, rmode), ADDRESS_LOAD); 4034 li(t9, Operand(target_int, rmode), ADDRESS_LOAD);
4038 Call(t9, cond, rs, rt, bd); 4035 Call(t9, cond, rs, rt, bd);
4039 DCHECK_EQ(CallSize(target, rmode, cond, rs, rt, bd), 4036 DCHECK_EQ(CallSize(target, rmode, cond, rs, rt, bd),
4040 SizeOfCodeGeneratedSince(&start)); 4037 SizeOfCodeGeneratedSince(&start));
4041 } 4038 }
4042 4039
4043 4040
4044 int MacroAssembler::CallSize(Handle<Code> code, 4041 int MacroAssembler::CallSize(Handle<Code> code,
4045 RelocInfo::Mode rmode, 4042 RelocInfo::Mode rmode,
4046 TypeFeedbackId ast_id, 4043 TypeFeedbackId ast_id,
(...skipping 3096 matching lines...) Expand 10 before | Expand all | Expand 10 after
7143 if (mag.shift > 0) sra(result, result, mag.shift); 7140 if (mag.shift > 0) sra(result, result, mag.shift);
7144 srl(at, dividend, 31); 7141 srl(at, dividend, 31);
7145 Addu(result, result, Operand(at)); 7142 Addu(result, result, Operand(at));
7146 } 7143 }
7147 7144
7148 7145
7149 } // namespace internal 7146 } // namespace internal
7150 } // namespace v8 7147 } // namespace v8
7151 7148
7152 #endif // V8_TARGET_ARCH_MIPS64 7149 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/mips64/assembler-mips64.cc ('k') | src/ppc/assembler-ppc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698