Make code compile with clang_use_chrome_plugin (part III)

Make code compile with clang_use_chrome_plugin (part III)

This change contains files in xfa/fxbarcode directory.
This is part of the efforts to make PDFium code compilable
by Clang chromium style plugins.

The changes are mainly the following:
-- move inline constructor/destructor of complex class/struct out-of-line;
-- add constructor/destructor of complex class/struct if not
 explicitly defined;
-- add explicit out-of-line copy constructor when needed;
-- move inline virtual functions out-of-line;
-- Properly mark virtual functions with 'override';
-- some minor cleanups;

BUG=pdfium:469
Committed: https://pdfium.googlesource.com/pdfium/+/29b8ad0b130ec6ed4f72ebd0c0a4f9e6a5b03467

[Wei Li, 2016-06-14 17:56:20]

Description was changed from

==========
Make code compile with clang_use_chrome_plugin (part III)

This change contains files in core directory which were not covered
in part I. This is part of the efforts to make PDFium code compilable
by Clang chromium style plugins.

The changes are mainly the following:
-- move inline constructor/destructor of complex class/struct out-of-line;
-- add constructor/destructor of complex class/struct if not
 explicitly defined;
-- add explicit out-of-line copy constructor when needed;
-- move inline virtual functions out-of-line;
-- Properly mark virtual functions with 'override';
-- some minor cleanups;

BUG=pdfium:469
==========

to

==========
Make code compile with clang_use_chrome_plugin (part III)

This change contains files in xfa/fxbarcode directory. This is part of the
efforts to make PDFium code compilable
by Clang chromium style plugins.

The changes are mainly the following:
-- move inline constructor/destructor of complex class/struct out-of-line;
-- add constructor/destructor of complex class/struct if not
 explicitly defined;
-- add explicit out-of-line copy constructor when needed;
-- move inline virtual functions out-of-line;
-- Properly mark virtual functions with 'override';
-- some minor cleanups;

BUG=pdfium:469
==========

[Wei Li, 2016-06-14 17:56:48]

Description was changed from

==========
Make code compile with clang_use_chrome_plugin (part III)

This change contains files in xfa/fxbarcode directory. This is part of the
efforts to make PDFium code compilable
by Clang chromium style plugins.

The changes are mainly the following:
-- move inline constructor/destructor of complex class/struct out-of-line;
-- add constructor/destructor of complex class/struct if not
 explicitly defined;
-- add explicit out-of-line copy constructor when needed;
-- move inline virtual functions out-of-line;
-- Properly mark virtual functions with 'override';
-- some minor cleanups;

BUG=pdfium:469
==========

to

==========
Make code compile with clang_use_chrome_plugin (part III)

This change contains files in xfa/fxbarcode directory.
This is part of the efforts to make PDFium code compilable
by Clang chromium style plugins.

The changes are mainly the following:
-- move inline constructor/destructor of complex class/struct out-of-line;
-- add constructor/destructor of complex class/struct if not
 explicitly defined;
-- add explicit out-of-line copy constructor when needed;
-- move inline virtual functions out-of-line;
-- Properly mark virtual functions with 'override';
-- some minor cleanups;

BUG=pdfium:469
==========

[Wei Li, 2016-06-14 23:52:18]

weili@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Wei Li, 2016-06-14 23:52:19]

pls review, thanks

[Lei Zhang, 2016-06-15 00:04:30]

https://codereview.chromium.org/2067903002/diff/60001/xfa/fxbarcode/common/BC...
File xfa/fxbarcode/common/BC_CommonBitMatrix.h (right):

https://codereview.chromium.org/2067903002/diff/60001/xfa/fxbarcode/common/BC...
xfa/fxbarcode/common/BC_CommonBitMatrix.h:36: virtual void Init(int32_t
dimension);
You may want to move the virtual methods up into their own section.

https://codereview.chromium.org/2067903002/diff/60001/xfa/fxbarcode/common/BC...
File xfa/fxbarcode/common/BC_CommonBitSource.h (right):

https://codereview.chromium.org/2067903002/diff/60001/xfa/fxbarcode/common/BC...
xfa/fxbarcode/common/BC_CommonBitSource.h:16: virtual ~CBC_CommonBitSource();
No need to be virtual? Maybe we can examine all the classes with virtual dtors
but no virtual methods separately.

https://codereview.chromium.org/2067903002/diff/60001/xfa/fxbarcode/common/BC...
File xfa/fxbarcode/common/BC_WhiteRectangleDetector.h (right):

https://codereview.chromium.org/2067903002/diff/60001/xfa/fxbarcode/common/BC...
xfa/fxbarcode/common/BC_WhiteRectangleDetector.h:27: int32_t Round(FX_FLOAT d);
Not obvious why this needs to be public.

https://codereview.chromium.org/2067903002/diff/60001/xfa/fxbarcode/datamatri...
File xfa/fxbarcode/datamatrix/BC_DataMatrixDetector.cpp (right):

https://codereview.chromium.org/2067903002/diff/60001/xfa/fxbarcode/datamatri...
xfa/fxbarcode/datamatrix/BC_DataMatrixDetector.cpp:413: m_from = from;
Use the initializer list instead?

https://codereview.chromium.org/2067903002/diff/60001/xfa/fxbarcode/oned/BC_O...
File xfa/fxbarcode/oned/BC_OnedEAN13Reader.h (right):

https://codereview.chromium.org/2067903002/diff/60001/xfa/fxbarcode/oned/BC_O...
xfa/fxbarcode/oned/BC_OnedEAN13Reader.h:24: private:
BTW, private ahead of protected.

https://codereview.chromium.org/2067903002/diff/60001/xfa/fxbarcode/oned/BC_O...
File xfa/fxbarcode/oned/BC_OnedEAN8Writer.h (right):

https://codereview.chromium.org/2067903002/diff/60001/xfa/fxbarcode/oned/BC_O...
xfa/fxbarcode/oned/BC_OnedEAN8Writer.h:19: private:
Another private section that's out of place.

[Wei Li, 2016-06-15 00:32:39]

thanks

https://codereview.chromium.org/2067903002/diff/60001/xfa/fxbarcode/common/BC...
File xfa/fxbarcode/common/BC_CommonBitMatrix.h (right):

https://codereview.chromium.org/2067903002/diff/60001/xfa/fxbarcode/common/BC...
xfa/fxbarcode/common/BC_CommonBitMatrix.h:36: virtual void Init(int32_t
dimension);
On 2016/06/15 00:04:30, Lei Zhang wrote:
> You may want to move the virtual methods up into their own section.

Done.

https://codereview.chromium.org/2067903002/diff/60001/xfa/fxbarcode/common/BC...
File xfa/fxbarcode/common/BC_CommonBitSource.h (right):

https://codereview.chromium.org/2067903002/diff/60001/xfa/fxbarcode/common/BC...
xfa/fxbarcode/common/BC_CommonBitSource.h:16: virtual ~CBC_CommonBitSource();
On 2016/06/15 00:04:30, Lei Zhang wrote:
> No need to be virtual? Maybe we can examine all the classes with virtual dtors
> but no virtual methods separately.

Done.

https://codereview.chromium.org/2067903002/diff/60001/xfa/fxbarcode/common/BC...
File xfa/fxbarcode/common/BC_WhiteRectangleDetector.h (right):

https://codereview.chromium.org/2067903002/diff/60001/xfa/fxbarcode/common/BC...
xfa/fxbarcode/common/BC_WhiteRectangleDetector.h:27: int32_t Round(FX_FLOAT d);
On 2016/06/15 00:04:30, Lei Zhang wrote:
> Not obvious why this needs to be public.

Done.

https://codereview.chromium.org/2067903002/diff/60001/xfa/fxbarcode/datamatri...
File xfa/fxbarcode/datamatrix/BC_DataMatrixDetector.cpp (right):

https://codereview.chromium.org/2067903002/diff/60001/xfa/fxbarcode/datamatri...
xfa/fxbarcode/datamatrix/BC_DataMatrixDetector.cpp:413: m_from = from;
On 2016/06/15 00:04:30, Lei Zhang wrote:
> Use the initializer list instead?

Done.

https://codereview.chromium.org/2067903002/diff/60001/xfa/fxbarcode/oned/BC_O...
File xfa/fxbarcode/oned/BC_OnedEAN13Reader.h (right):

https://codereview.chromium.org/2067903002/diff/60001/xfa/fxbarcode/oned/BC_O...
xfa/fxbarcode/oned/BC_OnedEAN13Reader.h:24: private:
On 2016/06/15 00:04:30, Lei Zhang wrote:
> BTW, private ahead of protected.

Done.

https://codereview.chromium.org/2067903002/diff/60001/xfa/fxbarcode/oned/BC_O...
File xfa/fxbarcode/oned/BC_OnedEAN8Writer.h (right):

https://codereview.chromium.org/2067903002/diff/60001/xfa/fxbarcode/oned/BC_O...
xfa/fxbarcode/oned/BC_OnedEAN8Writer.h:19: private:
On 2016/06/15 00:04:30, Lei Zhang wrote:
> Another private section that's out of place.

Done.

[Lei Zhang, 2016-06-15 00:34:01]

lgtm

[Lei Zhang, 2016-06-15 01:19:20]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-06-15 01:19:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2067903002/80001

[commit-bot: I haz the power, 2016-06-15 01:20:10]

Description was changed from

==========
Make code compile with clang_use_chrome_plugin (part III)

This change contains files in xfa/fxbarcode directory.
This is part of the efforts to make PDFium code compilable
by Clang chromium style plugins.

The changes are mainly the following:
-- move inline constructor/destructor of complex class/struct out-of-line;
-- add constructor/destructor of complex class/struct if not
 explicitly defined;
-- add explicit out-of-line copy constructor when needed;
-- move inline virtual functions out-of-line;
-- Properly mark virtual functions with 'override';
-- some minor cleanups;

BUG=pdfium:469
==========

to

==========
Make code compile with clang_use_chrome_plugin (part III)

This change contains files in xfa/fxbarcode directory.
This is part of the efforts to make PDFium code compilable
by Clang chromium style plugins.

The changes are mainly the following:
-- move inline constructor/destructor of complex class/struct out-of-line;
-- add constructor/destructor of complex class/struct if not
 explicitly defined;
-- add explicit out-of-line copy constructor when needed;
-- move inline virtual functions out-of-line;
-- Properly mark virtual functions with 'override';
-- some minor cleanups;

BUG=pdfium:469

Committed:
https://pdfium.googlesource.com/pdfium/+/29b8ad0b130ec6ed4f72ebd0c0a4f9e6a5b0...
==========

[commit-bot: I haz the power, 2016-06-15 01:20:11]

Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/29b8ad0b130ec6ed4f72ebd0c0a4f9e6a5b0...