Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3273)

Unified Diff: xfa/fxbarcode/oned/BC_OneDimReader.h

Issue 2067903002: Make code compile with clang_use_chrome_plugin (part III) (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: address comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/fxbarcode/oned/BC_OneDReader.cpp ('k') | xfa/fxbarcode/oned/BC_OneDimWriter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fxbarcode/oned/BC_OneDimReader.h
diff --git a/xfa/fxbarcode/oned/BC_OneDimReader.h b/xfa/fxbarcode/oned/BC_OneDimReader.h
index f572d6fd1ef2c709818c408cc6fee1474e9dbe35..bd46a189f4ab23c4a9d852becc839602e4ed43f0 100644
--- a/xfa/fxbarcode/oned/BC_OneDimReader.h
+++ b/xfa/fxbarcode/oned/BC_OneDimReader.h
@@ -26,17 +26,19 @@ class CBC_OneDimReader : public CBC_OneDReader {
static const int32_t L_AND_G_PATTERNS[20][4];
CBC_OneDimReader();
- virtual ~CBC_OneDimReader();
+ ~CBC_OneDimReader() override;
+ // CBC_OneDReader
CFX_ByteString DecodeRow(int32_t rowNumber,
CBC_CommonBitArray* row,
int32_t hints,
- int32_t& e);
- CFX_ByteString DecodeRow(int32_t rowNumber,
- CBC_CommonBitArray* row,
- CFX_Int32Array* startGuardRange,
- int32_t hints,
- int32_t& e);
+ int32_t& e) override;
+
+ virtual CFX_ByteString DecodeRow(int32_t rowNumber,
+ CBC_CommonBitArray* row,
+ CFX_Int32Array* startGuardRange,
+ int32_t hints,
+ int32_t& e);
protected:
CFX_Int32Array* FindStartGuardPattern(CBC_CommonBitArray* row, int32_t& e);
@@ -55,9 +57,7 @@ class CBC_OneDimReader : public CBC_OneDReader {
virtual int32_t DecodeMiddle(CBC_CommonBitArray* row,
CFX_Int32Array* startRange,
CFX_ByteString& resultResult,
- int32_t& e) {
- return 0;
- }
+ int32_t& e) = 0;
virtual CFX_Int32Array* DecodeEnd(CBC_CommonBitArray* row,
int32_t endStart,
int32_t& e);
« no previous file with comments | « xfa/fxbarcode/oned/BC_OneDReader.cpp ('k') | xfa/fxbarcode/oned/BC_OneDimWriter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698