xfa/fxbarcode/common/BC_CommonBitSource.h - Issue 2067903002: Make code compile with clang_use_chrome_plugin (part III)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: xfa/fxbarcode/common/BC_CommonBitSource.h

Issue 2067903002: Make code compile with clang_use_chrome_plugin (part III) (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: fix comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« xfa/fxbarcode/common/BC_CommonBitMatrix.h ('K') | « xfa/fxbarcode/common/BC_CommonBitMatrix.h ('k') | xfa/fxbarcode/common/BC_CommonByteArray.h » ('j') | xfa/fxbarcode/common/BC_WhiteRectangleDetector.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

7 #ifndef XFA_FXBARCODE_COMMON_BC_COMMONBITSOURCE_H_	7 #ifndef XFA_FXBARCODE_COMMON_BC_COMMONBITSOURCE_H_

8 #define XFA_FXBARCODE_COMMON_BC_COMMONBITSOURCE_H_	8 #define XFA_FXBARCODE_COMMON_BC_COMMONBITSOURCE_H_

9	9

10 #include "core/fxcrt/include/fx_basic.h"	10 #include "core/fxcrt/include/fx_basic.h"

11 #include "xfa/fxbarcode/utils.h"	11 #include "xfa/fxbarcode/utils.h"

12	12

13 class CBC_CommonBitSource {	13 class CBC_CommonBitSource {

14 public:	14 public:

15 CBC_CommonBitSource(CFX_ByteArray* bytes);	15 CBC_CommonBitSource(CFX_ByteArray* bytes);

16 virtual ~CBC_CommonBitSource();	16 virtual ~CBC_CommonBitSource();
	Lei Zhang 2016/06/15 00:04:30 No need to be virtual? Maybe we can examine all th No need to be virtual? Maybe we can examine all the classes with virtual dtors but no virtual methods separately. Wei Li 2016/06/15 00:32:39 Done. Show quoted text On 2016/06/15 00:04:30, Lei Zhang wrote: > No need to be virtual? Maybe we can examine all the classes with virtual dtors > but no virtual methods separately. Done.
	17

17 int32_t ReadBits(int32_t numBits, int32_t& e);	18 int32_t ReadBits(int32_t numBits, int32_t& e);

18 int32_t Available();	19 int32_t Available();

19 int32_t getByteOffset();	20 int32_t getByteOffset();

20	21

21 private:	22 private:

22 CFX_ByteArray m_bytes;	23 CFX_ByteArray m_bytes;

23 int32_t m_byteOffset;	24 int32_t m_byteOffset;

24 int32_t m_bitOffset;	25 int32_t m_bitOffset;

25 };	26 };

26	27

27 #endif // XFA_FXBARCODE_COMMON_BC_COMMONBITSOURCE_H_	28 #endif // XFA_FXBARCODE_COMMON_BC_COMMONBITSOURCE_H_

OLD	NEW