xfa/fxbarcode/datamatrix/BC_ASCIIEncoder.h - Issue 2067903002: Make code compile with clang_use_chrome_plugin (part III)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxbarcode/datamatrix/BC_ASCIIEncoder.h

Issue 2067903002: Make code compile with clang_use_chrome_plugin (part III) (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxbarcode/datamatrix/BC_ASCIIEncoder.h

diff --git a/xfa/fxbarcode/datamatrix/BC_ASCIIEncoder.h b/xfa/fxbarcode/datamatrix/BC_ASCIIEncoder.h

index 11be5e046a416bb2907691e4793635c91e8eb4a6..40559b532d8396981ce4b3b66c41d8a0567dbcd2 100644

--- a/xfa/fxbarcode/datamatrix/BC_ASCIIEncoder.h

+++ b/xfa/fxbarcode/datamatrix/BC_ASCIIEncoder.h

@@ -14,9 +14,11 @@ class CBC_EncoderContext;

class CBC_ASCIIEncoder : public CBC_Encoder {

public:

CBC_ASCIIEncoder();

- virtual ~CBC_ASCIIEncoder();

- int32_t getEncodingMode();

- void Encode(CBC_EncoderContext& context, int32_t& e);

+ ~CBC_ASCIIEncoder() override;

+ // CBC_Encoder

+ int32_t getEncodingMode() override;

+ void Encode(CBC_EncoderContext& context, int32_t& e) override;

private:

static FX_WCHAR encodeASCIIDigits(FX_WCHAR digit1,