xfa/fxbarcode/common/BC_CommonCharacterSetECI.h - Issue 2067903002: Make code compile with clang_use_chrome_plugin (part III)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxbarcode/common/BC_CommonCharacterSetECI.h

Issue 2067903002: Make code compile with clang_use_chrome_plugin (part III) (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxbarcode/common/BC_CommonCharacterSetECI.h

diff --git a/xfa/fxbarcode/common/BC_CommonCharacterSetECI.h b/xfa/fxbarcode/common/BC_CommonCharacterSetECI.h

index 5bd77e4fd15890d23c3fc4e88997e08e877cb70e..a2fe0ed2fe3e05c9caec6ae6aefcec0be74ece0f 100644

--- a/xfa/fxbarcode/common/BC_CommonCharacterSetECI.h

+++ b/xfa/fxbarcode/common/BC_CommonCharacterSetECI.h

@@ -13,10 +13,10 @@

class CBC_CommonCharacterSetECI : public CBC_CommonECI {

public:

CBC_CommonCharacterSetECI(int32_t value, CFX_ByteString encodingName);

- virtual ~CBC_CommonCharacterSetECI();

+ ~CBC_CommonCharacterSetECI() override;

CFX_ByteString GetEncodingName();

static void AddCharacterSet(int32_t value, CFX_ByteString encodingName);

- int32_t GetValue();

static CBC_CommonCharacterSetECI* GetCharacterSetECIByValue(int32_t value);

static CBC_CommonCharacterSetECI* GetCharacterSetECIByName(

const CFX_ByteString& name);