xfa/fxbarcode/common/BC_CommonECI.h - Issue 2067903002: Make code compile with clang_use_chrome_plugin (part III)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxbarcode/common/BC_CommonECI.h

Issue 2067903002: Make code compile with clang_use_chrome_plugin (part III) (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxbarcode/common/BC_CommonECI.h

diff --git a/xfa/fxbarcode/common/BC_CommonECI.h b/xfa/fxbarcode/common/BC_CommonECI.h

index 20b3e76bb3865d79a39502ae3b3049bc59fccfa8..5bc4c1485c98cced0c1a3d0ba7135f62a7570b4b 100644

--- a/xfa/fxbarcode/common/BC_CommonECI.h

+++ b/xfa/fxbarcode/common/BC_CommonECI.h

@@ -14,7 +14,8 @@ class CBC_CommonECI {

CBC_CommonECI(int32_t value);

virtual ~CBC_CommonECI();

- int32_t GetValue();

+ virtual int32_t GetValue();

static CBC_CommonECI* GetEICByValue(int32_t value, int32_t& e);

private: