Use DCHECKs when observing only a single notification.

Use DCHECKs when observing only a single notification.

In various places in chrome/browser.

Committed: https://crrev.com/52835794be3b6a6b5c3db1888685fdb845a29998
Cr-Commit-Position: refs/heads/master@{#399536}

[Lei Zhang, 2016-06-13 18:29:26]

thestig@chromium.org changed reviewers:
+ tommycli@chromium.org, xiyuan@chromium.org

[Lei Zhang, 2016-06-13 18:29:27]

xiyuan: chromeos
tommycli: non-chromeos

[xiyuan, 2016-06-13 19:04:29]

chromeos/* LGTM

[tommycli, 2016-06-13 19:20:34]

Some of these changes will alter the release-mode behavior.

Whereas previously an unexpected notification type would be a no-op with an
ignored NOTREACHED(). Now, it would fail the DCHECK and then actually perform
the action.

This new model seems to follow the Chromium style guide of "do not handle DCHECK
failures", so this is lgtm.

I just wanted to confirm that the release-mode behavior changes are intentional.

Cheers,

Tommy

[Lei Zhang, 2016-06-13 19:31:07]

On 2016/06/13 19:20:34, tommycli wrote:
> Some of these changes will alter the release-mode behavior.
> 
> Whereas previously an unexpected notification type would be a no-op with an
> ignored NOTREACHED(). Now, it would fail the DCHECK and then actually perform
> the action.
> 
> This new model seems to follow the Chromium style guide of "do not handle
DCHECK
> failures", so this is lgtm.
> 
> I just wanted to confirm that the release-mode behavior changes are
intentional.

Correct. The NOTREACHED are never reached w.r.t. notifications.
NotificationRegistrar is fairly stable and won't ever get this wrong.

[Lei Zhang, 2016-06-13 19:31:13]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-06-13 19:32:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2063863002/1

[commit-bot: I haz the power, 2016-06-13 21:08:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-13 21:08:40]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-13 21:11:11]

Description was changed from

==========
Use DCHECKs when observing only a single notification.

In various places in chrome/browser.
==========

to

==========
Use DCHECKs when observing only a single notification.

In various places in chrome/browser.

Committed: https://crrev.com/52835794be3b6a6b5c3db1888685fdb845a29998
Cr-Commit-Position: refs/heads/master@{#399536}
==========

[commit-bot: I haz the power, 2016-06-13 21:11:13]

Patchset 1 (id:??) landed as
https://crrev.com/52835794be3b6a6b5c3db1888685fdb845a29998
Cr-Commit-Position: refs/heads/master@{#399536}