chrome/browser/service_process/service_process_control.cc - Issue 2063863002: Use DCHECKs when observing only a single notification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/service_process/service_process_control.cc

Issue 2063863002: Use DCHECKs when observing only a single notification. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/client_side_detection_service.cc ('k') | chrome/browser/spellchecker/spellcheck_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/service_process/service_process_control.cc

diff --git a/chrome/browser/service_process/service_process_control.cc b/chrome/browser/service_process/service_process_control.cc

index 796ed4fbdb1b505bee741181f960d4ff74a9639c..99769c5e48cd33cb902c202f61b2e3589a9792a9 100644

--- a/chrome/browser/service_process/service_process_control.cc

+++ b/chrome/browser/service_process/service_process_control.cc

@@ -204,9 +204,8 @@ void ServiceProcessControl::Observe(

int type,

const content::NotificationSource& source,

const content::NotificationDetails& details) {

- if (type == chrome::NOTIFICATION_UPGRADE_RECOMMENDED) {

- Send(new ServiceMsg_UpdateAvailable);

- }

+ DCHECK_EQ(chrome::NOTIFICATION_UPGRADE_RECOMMENDED, type);

+ Send(new ServiceMsg_UpdateAvailable);

}

void ServiceProcessControl::OnCloudPrintProxyInfo(

« no previous file with comments | « chrome/browser/safe_browsing/client_side_detection_service.cc ('k') | chrome/browser/spellchecker/spellcheck_service.cc » ('j') | no next file with comments »