chrome/browser/chromeos/policy/recommendation_restorer.cc - Issue 2063863002: Use DCHECKs when observing only a single notification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/recommendation_restorer.cc

Issue 2063863002: Use DCHECKs when observing only a single notification. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/cloud_external_data_policy_observer.cc ('k') | chrome/browser/download/chrome_download_manager_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/recommendation_restorer.cc

diff --git a/chrome/browser/chromeos/policy/recommendation_restorer.cc b/chrome/browser/chromeos/policy/recommendation_restorer.cc

index 68defa9949f4782e7f17ebc158745a3ffe178dea..40908a15683402d6f1d02b5407ec868896dceedc 100644

--- a/chrome/browser/chromeos/policy/recommendation_restorer.cc

+++ b/chrome/browser/chromeos/policy/recommendation_restorer.cc

@@ -77,14 +77,12 @@ void RecommendationRestorer::Observe(

int type,

const content::NotificationSource& source,

const content::NotificationDetails& details) {

- if (type == chrome::NOTIFICATION_LOGIN_USER_CHANGED) {

- logged_in_ = true;

- notification_registrar_.RemoveAll();

- StopTimer();

- RestoreAll();

- } else {

- NOTREACHED();

- }

+ DCHECK_EQ(chrome::NOTIFICATION_LOGIN_USER_CHANGED, type);

+ logged_in_ = true;

+ notification_registrar_.RemoveAll();

+ StopTimer();

+ RestoreAll();

}

void RecommendationRestorer::OnUserActivity(const ui::Event* event) {