chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc - Issue 2063863002: Use DCHECKs when observing only a single notification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

Issue 2063863002: Use DCHECKs when observing only a single notification. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/signin_screen_controller.cc ('k') | chrome/browser/chromeos/policy/cloud_external_data_policy_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

diff --git a/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc b/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

index e43930a79fb1d970d58f5f1ff3ed5b1ecf254318..881bc22c69017a59b9e01765ff9704c346e8de13 100644

--- a/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

+++ b/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc

@@ -345,10 +345,7 @@ void OwnerSettingsServiceChromeOS::Observe(

const content::NotificationSource& source,

const content::NotificationDetails& details) {

DCHECK(thread_checker_.CalledOnValidThread());

- if (type != chrome::NOTIFICATION_PROFILE_CREATED) {

- NOTREACHED();

- return;

- }

+ DCHECK_EQ(chrome::NOTIFICATION_PROFILE_CREATED, type);

Profile* profile = content::Source<Profile>(source).ptr();

if (profile != profile_) {