chrome/browser/chromeos/extensions/external_cache.cc - Issue 2063863002: Use DCHECKs when observing only a single notification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/external_cache.cc

Issue 2063863002: Use DCHECKs when observing only a single notification. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/drive/drive_integration_service.cc ('k') | chrome/browser/chromeos/first_run/drive_first_run_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/external_cache.cc

diff --git a/chrome/browser/chromeos/extensions/external_cache.cc b/chrome/browser/chromeos/extensions/external_cache.cc

index 1071cf89a5de6be5982414007171f59ba5211073..e848efeaac75940d16b132bf66a0bcaadcf23d11 100644

--- a/chrome/browser/chromeos/extensions/external_cache.cc

+++ b/chrome/browser/chromeos/extensions/external_cache.cc

@@ -154,17 +154,11 @@ void ExternalCache::PutExternalExtension(

void ExternalCache::Observe(int type,

const content::NotificationSource& source,

const content::NotificationDetails& details) {

- switch (type) {

- case extensions::NOTIFICATION_EXTENSION_INSTALL_ERROR: {

- extensions::CrxInstaller* installer =

- content::Source<extensions::CrxInstaller>(source).ptr();

- OnDamagedFileDetected(installer->source_file());

- break;

- }

+ DCHECK_EQ(extensions::NOTIFICATION_EXTENSION_INSTALL_ERROR, type);

- default:

- NOTREACHED();

- }

+ extensions::CrxInstaller* installer =

+ content::Source<extensions::CrxInstaller>(source).ptr();

+ OnDamagedFileDetected(installer->source_file());

}

void ExternalCache::OnExtensionDownloadFailed(