chrome/browser/plugins/plugin_status_pref_setter.cc - Issue 2063863002: Use DCHECKs when observing only a single notification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/plugins/plugin_status_pref_setter.cc

Issue 2063863002: Use DCHECKs when observing only a single notification. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/permission_bubble_media_access_handler.cc ('k') | chrome/browser/policy/cloud/user_cloud_policy_invalidator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/plugins/plugin_status_pref_setter.cc

diff --git a/chrome/browser/plugins/plugin_status_pref_setter.cc b/chrome/browser/plugins/plugin_status_pref_setter.cc

index c4ba835a4ea36574d1e751c9c15ebfbdde68b498..2fcb984d0e874e49ac0629c2fd9e36d5130aad96 100644

--- a/chrome/browser/plugins/plugin_status_pref_setter.cc

+++ b/chrome/browser/plugins/plugin_status_pref_setter.cc

@@ -44,11 +44,8 @@ void PluginStatusPrefSetter::Observe(

int type,

const content::NotificationSource& source,

const content::NotificationDetails& details) {

- if (type == chrome::NOTIFICATION_PLUGIN_ENABLE_STATUS_CHANGED) {

- StartUpdate();

- } else {

- NOTREACHED();

- }

+ DCHECK_EQ(chrome::NOTIFICATION_PLUGIN_ENABLE_STATUS_CHANGED, type);

+ StartUpdate();

}

void PluginStatusPrefSetter::StartUpdate() {