chrome/browser/ssl/ssl_client_auth_observer.cc - Issue 2063863002: Use DCHECKs when observing only a single notification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_client_auth_observer.cc

Issue 2063863002: Use DCHECKs when observing only a single notification. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ssl/ssl_client_auth_observer.cc

diff --git a/chrome/browser/ssl/ssl_client_auth_observer.cc b/chrome/browser/ssl/ssl_client_auth_observer.cc

index e071c68d5a27f4a681b5de4c02170a03a852edfc..794fff373e2663989bc5c82580e42afc1abc039d 100644

--- a/chrome/browser/ssl/ssl_client_auth_observer.cc

+++ b/chrome/browser/ssl/ssl_client_auth_observer.cc

@@ -67,7 +67,7 @@ void SSLClientAuthObserver::Observe(

const content::NotificationDetails& details) {

DVLOG(1) << "SSLClientAuthObserver::Observe " << this;

DCHECK_CURRENTLY_ON(BrowserThread::UI);

- DCHECK(type == chrome::NOTIFICATION_SSL_CLIENT_AUTH_CERT_SELECTED);

+ DCHECK_EQ(chrome::NOTIFICATION_SSL_CLIENT_AUTH_CERT_SELECTED, type);

CertDetails* cert_details = content::Details<CertDetails>(details).ptr();

if (!cert_details->first->host_and_port.Equals(

« no previous file with comments | « chrome/browser/ssl/captive_portal_metrics_recorder.cc ('k') | chrome/browser/ssl/ssl_error_handler.cc » ('j') | no next file with comments »