[builtins] Introduce proper Float64Log1p operator.

[builtins] Introduce proper Float64Log1p operator.

Import base::ieee754::log1p() from fdlibm and introduce a Float64Log1p
TurboFan operator based on that, similar to what we do for Float64Log.
Rewrite Math.log1p() as TurboFan builtin and use that operator to also
inline Math.log1p() into optimized TurboFan functions.

Also unify the handling of the special IEEE 754 functions somewhat in
the TurboFan backends. At some point we can hopefully express this
completely in the InstructionSelector (once we have an idea what to do
with the ST(0) return issue on IA-32/X87).

Drive-by-fix: Add some more test coverage for the log function.

R=yangguo@chromium.org
BUG=v8:5086, v8:5092
Committed: https://crrev.com/7ceed92ac036d6b4e402d76a5cea130a3c4cfbf1
Cr-Commit-Position: refs/heads/master@{#36914}

[Benedikt Meurer, 2016-06-13 05:15:52]

Hey Yang,

Here's log1p unified.
Please take a look.

Thanks,
Benedikt

[Benedikt Meurer, 2016-06-13 05:18:18]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-13 05:18:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2060743002/20001

[Yang, 2016-06-13 05:36:34]

lgtm

https://codereview.chromium.org/2060743002/diff/20001/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/2060743002/diff/20001/src/builtins.cc#newcode...
src/builtins.cc:2486: assembler->Return(result);
If only we could reduce duplicate code for these sort of builtins (Math.log,
Math.log1p, Math.sqrt and future ones) :)

[Benedikt Meurer, 2016-06-13 05:38:21]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2016-06-13 05:39:38]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-06-13 05:39:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2060743002/20001

[Benedikt Meurer, 2016-06-13 05:40:17]

https://codereview.chromium.org/2060743002/diff/20001/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/2060743002/diff/20001/src/builtins.cc#newcode...
src/builtins.cc:2486: assembler->Return(result);
On 2016/06/13 05:36:33, Yang wrote:
> If only we could reduce duplicate code for these sort of builtins (Math.log,
> Math.log1p, Math.sqrt and future ones) :)

Acknowledged.

[commit-bot: I haz the power, 2016-06-13 05:46:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-13 05:48:09]

Description was changed from

==========
[builtins] Introduce proper Float64Log1p operator.

Import base::ieee754::log1p() from fdlibm and introduce a Float64Log1p
TurboFan operator based on that, similar to what we do for Float64Log.
Rewrite Math.log1p() as TurboFan builtin and use that operator to also
inline Math.log1p() into optimized TurboFan functions.

Also unify the handling of the special IEEE 754 functions somewhat in
the TurboFan backends. At some point we can hopefully express this
completely in the InstructionSelector (once we have an idea what to do
with the ST(0) return issue on IA-32/X87).

Drive-by-fix: Add some more test coverage for the log function.

R=yangguo@chromium.org
BUG=v8:5086,v8:5092
==========

to

==========
[builtins] Introduce proper Float64Log1p operator.

Import base::ieee754::log1p() from fdlibm and introduce a Float64Log1p
TurboFan operator based on that, similar to what we do for Float64Log.
Rewrite Math.log1p() as TurboFan builtin and use that operator to also
inline Math.log1p() into optimized TurboFan functions.

Also unify the handling of the special IEEE 754 functions somewhat in
the TurboFan backends. At some point we can hopefully express this
completely in the InstructionSelector (once we have an idea what to do
with the ST(0) return issue on IA-32/X87).

Drive-by-fix: Add some more test coverage for the log function.

R=yangguo@chromium.org
BUG=v8:5086,v8:5092

Committed: https://crrev.com/7ceed92ac036d6b4e402d76a5cea130a3c4cfbf1
Cr-Commit-Position: refs/heads/master@{#36914}
==========

[commit-bot: I haz the power, 2016-06-13 05:48:10]

Patchset 2 (id:??) landed as
https://crrev.com/7ceed92ac036d6b4e402d76a5cea130a3c4cfbf1
Cr-Commit-Position: refs/heads/master@{#36914}

[Michael Achenbach, 2016-06-27 07:45:34]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2016-06-27 07:45:35]

https://codereview.chromium.org/2060743002/diff/20001/test/unittests/unittest...
File test/unittests/unittests.gyp (right):

https://codereview.chromium.org/2060743002/diff/20001/test/unittests/unittest...
test/unittests/unittests.gyp:34: 'base/ieee754-unittest.cc',
Note: This unittest will stop running when we switch to GN if not specified in
BUILD.gn.