Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2049063002: Revert of Use element id's for animations (Closed)

Created:
4 years, 6 months ago by Ian Vollick
Modified:
4 years, 6 months ago
CC:
darktears, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-api_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, Eric Willigers, f(malita), jbauman+watch_chromium.org, jchaffraix+rendering, Justin Novosad, kalyank, kinuko+watch, leviw+renderwatch, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, piman+watch_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, sievers+watch_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use element id's for animations (patchset #34 id:650001 of https://codereview.chromium.org/1973083002/ ) Reason for revert: This caused: https://bugs.chromium.org/p/chromium/issues/detail?id=618286 Original issue's description: > Use element id's for animations. > > The goal of this CL is to migrate cc's animation code > away from layer id's in anticipation of SPv2. The ids > chosen are a minor tweak on DOMNodeIds for blink. > > Other clients of cc may essentially continue using > their respective layer id's as identifiers. cc itself > remains ignorant of the semantic meaning of these ids, > treating them as an opaque identifier. > > This change is extremely similar to loyso@'s earlier > CL crrev.com/1944623002, the significant difference > being the scheme for choosing the ids. > > Notable changes in this CL > * Introduces an ElementId structure. > * Augments DOMNodeIds in order to handle sub elements (eg, for scroll and link highlight layers). > * Removal of ElementLayers from cc > > BUG=616542 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/51659f1ad58fc058ebb95907734ce6b2c887898d > Cr-Commit-Position: refs/heads/master@{#398366} TBR=jbroman@chromium.org,ajuma@chromium.org,bokan@chromium.org,loyso@chromium.org,rbyers@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=616542 Committed: https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e Cr-Commit-Position: refs/heads/master@{#398537}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+575 lines, -965 lines) Patch
M cc/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/animation/animation_host.h View 1 chunk +1 line, -3 lines 0 comments Download
M cc/animation/animation_host.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M cc/animation/animation_host_perftest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/animation/animation_player.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M cc/animation/animation_player_unittest.cc View 5 chunks +17 lines, -17 lines 0 comments Download
M cc/animation/element_animations_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D cc/animation/element_id.h View 1 chunk +0 lines, -81 lines 0 comments Download
D cc/animation/element_id.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M cc/animation/scroll_offset_animations.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/blink/web_layer_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/blink/web_layer_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M cc/cc.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
M cc/input/scroll_state_data.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/input/scroll_state_data.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M cc/layers/layer.h View 3 chunks +3 lines, -4 lines 0 comments Download
M cc/layers/layer.cc View 4 chunks +3 lines, -26 lines 0 comments Download
M cc/layers/layer_impl.h View 3 chunks +3 lines, -4 lines 0 comments Download
M cc/layers/layer_impl.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M cc/layers/layer_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/layer_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/layers/layer_utils_unittest.cc View 15 chunks +28 lines, -34 lines 0 comments Download
M cc/proto/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D cc/proto/element_id.proto View 1 chunk +0 lines, -18 lines 0 comments Download
M cc/proto/property_tree.proto View 3 chunks +2 lines, -3 lines 0 comments Download
M cc/test/animation_test_common.h View 2 chunks +20 lines, -22 lines 0 comments Download
M cc/test/animation_test_common.cc View 5 chunks +29 lines, -30 lines 0 comments Download
M cc/test/animation_timelines_test_common.h View 3 chunks +6 lines, -6 lines 0 comments Download
M cc/test/animation_timelines_test_common.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M cc/test/layer_test_common.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host.h View 3 chunks +0 lines, -10 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 10 chunks +25 lines, -59 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 41 chunks +77 lines, -123 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 8 chunks +18 lines, -27 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 14 chunks +16 lines, -38 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 31 chunks +37 lines, -45 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 4 chunks +12 lines, -10 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 12 chunks +54 lines, -52 lines 0 comments Download
M cc/trees/mutator_host_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/property_tree.h View 2 chunks +1 line, -2 lines 0 comments Download
M cc/trees/property_tree.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/Animation.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CompositorAnimations.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CompositorAnimations.cpp View 2 chunks +29 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffect.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffect.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.cpp View 3 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 2 chunks +25 lines, -47 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.h View 2 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/platform/graphics/CompositorElementId.h View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/Source/platform/graphics/CompositorElementId.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CompositorMutableStateProvider.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp View 5 chunks +22 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp View 3 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp View 6 chunks +18 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/web/LinkHighlightImpl.cpp View 3 chunks +4 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp View 6 chunks +13 lines, -10 lines 0 comments Download
M third_party/WebKit/public/platform/WebLayer.h View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/compositor/layer.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/compositor/layer_animator.cc View 3 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Ian Vollick
Created Revert of Use element id's for animations
4 years, 6 months ago (2016-06-08 13:40:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049063002/1
4 years, 6 months ago (2016-06-08 13:41:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 13:42:48 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 13:44:05 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8f64cb037cd9b5c9eda8419d6ab778662702a6e
Cr-Commit-Position: refs/heads/master@{#398537}

Powered by Google App Engine
This is Rietveld 408576698