DevTools: update V8Inspector to work with the new v8_inspector API.

DevTools: update V8Inspector to work with the new v8_inspector API.

BUG=580337
NOTRY=true

Committed: https://crrev.com/e29769c698f0a678689e0d1e0679963e18c9d581
Cr-Commit-Position: refs/heads/master@{#398675}

[pfeldman, 2016-06-08 06:29:59]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-08 06:30:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2044343002/1

[commit-bot: I haz the power, 2016-06-08 06:51:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 06:51:36]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[pfeldman, 2016-06-08 15:45:38]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[pfeldman, 2016-06-08 15:55:31]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-08 15:55:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2044343002/20001

[dgozman, 2016-06-08 15:56:56]

lgtm

https://codereview.chromium.org/2044343002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/inspector_protocol/String16STL.cpp
(right):

https://codereview.chromium.org/2044343002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/inspector_protocol/String16STL.cpp:13:
#define DCHECK(k)
Not needed, as you have it in Platform.h

[commit-bot: I haz the power, 2016-06-08 17:01:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 17:01:17]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[alph, 2016-06-08 17:18:47]

alph@chromium.org changed reviewers:
+ alph@chromium.org

[alph, 2016-06-08 17:18:48]

https://codereview.chromium.org/2044343002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/inspector_protocol/CollectionsSTL.h
(right):

https://codereview.chromium.org/2044343002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/inspector_protocol/CollectionsSTL.h:178:
std::map<K, V> m_impl;
Why it became ordered? I don't see where ordering semantics is used.

[pfeldman, 2016-06-08 18:33:57]

> Why it became ordered? I don't see where ordering semantics is used.

Node 6 chain does not have c++11. It'll resolve soonish.

[alph, 2016-06-08 18:41:31]

On 2016/06/08 18:33:57, pfeldman wrote:
> > Why it became ordered? I don't see where ordering semantics is used.
> 
> Node 6 chain does not have c++11. It'll resolve soonish.

Ahh, I see. A FIXME would be nice to have there in this case.

[pfeldman, 2016-06-08 18:52:57]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-08 18:53:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2044343002/40001

[pfeldman, 2016-06-08 19:01:36]

Description was changed from

==========
DevTools: update V8Inspector to work with the new v8_inspector API.

BUG=580337
==========

to

==========
DevTools: update V8Inspector to work with the new v8_inspector API.

BUG=580337
==========

[pfeldman, 2016-06-08 19:01:36]

pfeldman@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org

[pfeldman, 2016-06-08 19:02:01]

On 2016/06/08 18:53:40, commit-bot: I haz the power wrote:
> Dry run: CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/2044343002/40001

+kozyatinskiy so that he stopped breaking it.

[pfeldman, 2016-06-08 21:06:43]

Description was changed from

==========
DevTools: update V8Inspector to work with the new v8_inspector API.

BUG=580337
==========

to

==========
DevTools: update V8Inspector to work with the new v8_inspector API.

BUG=580337
NOTRY=true
==========

[pfeldman, 2016-06-08 21:06:51]

The CQ bit was unchecked by pfeldman@chromium.org

[pfeldman, 2016-06-08 21:06:59]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-06-08 21:06:59]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2044343002/#ps40001
(title: "review comment addressed")

[commit-bot: I haz the power, 2016-06-08 21:07:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2044343002/40001

[commit-bot: I haz the power, 2016-06-08 21:15:59]

Description was changed from

==========
DevTools: update V8Inspector to work with the new v8_inspector API.

BUG=580337
NOTRY=true
==========

to

==========
DevTools: update V8Inspector to work with the new v8_inspector API.

BUG=580337
NOTRY=true
==========

[commit-bot: I haz the power, 2016-06-08 21:16:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-08 21:19:12]

Description was changed from

==========
DevTools: update V8Inspector to work with the new v8_inspector API.

BUG=580337
NOTRY=true
==========

to

==========
DevTools: update V8Inspector to work with the new v8_inspector API.

BUG=580337
NOTRY=true

Committed: https://crrev.com/e29769c698f0a678689e0d1e0679963e18c9d581
Cr-Commit-Position: refs/heads/master@{#398675}
==========

[commit-bot: I haz the power, 2016-06-08 21:19:14]

Patchset 3 (id:??) landed as
https://crrev.com/e29769c698f0a678689e0d1e0679963e18c9d581
Cr-Commit-Position: refs/heads/master@{#398675}