third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py - Issue 2044343002: DevTools: update V8Inspector to work with the new v8_inspector API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py

Issue 2044343002: DevTools: update V8Inspector to work with the new v8_inspector API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comment addressed Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/inspector_protocol/BackendCallback.h ('k') | third_party/WebKit/Source/platform/inspector_protocol/Collections.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py b/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py

index fca1920a0989e7a021ad10873aae8fe482083550..5c854eee938160ac2d7a434fc0b96f85dbfe41dc 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py

+++ b/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py

@@ -4,9 +4,7 @@

import os.path

import sys

-import string

import optparse

-import re

try:

import json

except ImportError:

@@ -203,6 +201,11 @@ def create_primitive_type_definition(type):

"integer": "int",

"boolean": "bool"

}

+ defaults = {

+ "number": "0",

+ "integer": "0",

+ "boolean": "false"

+ }

jsontypes = {

"number": "TypeNumber",

"integer": "TypeNumber",

@@ -218,8 +221,10 @@ def create_primitive_type_definition(type):

"raw_type": typedefs[type],

"raw_pass_type": typedefs[type],

"raw_return_type": typedefs[type],

+ "default_value": defaults[type]

}

type_definitions = {}

type_definitions["number"] = create_primitive_type_definition("number")

type_definitions["integer"] = create_primitive_type_definition("integer")