Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h

Issue 2044343002: DevTools: update V8Inspector to work with the new v8_inspector API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comment addressed Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h
index 494aaadd90a37128c3db2211e4e3b570a472d6e3..38bbc88774cf9c5b3086138bc728cec2983eaacc 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h
@@ -5,11 +5,11 @@
#ifndef V8Inspector_h
#define V8Inspector_h
+#include "platform/inspector_protocol/Platform.h"
#include "platform/v8_inspector/public/V8DebuggerClient.h"
#include "platform/v8_inspector/public/V8InspectorSession.h"
#include "platform/v8_inspector/public/V8InspectorSessionClient.h"
-#include "wtf/PtrUtil.h"
#include <v8.h>
namespace blink {
@@ -25,7 +25,6 @@ class V8HeapProfilerAgent;
class V8ProfilerAgent;
class V8Inspector : public V8DebuggerClient, V8InspectorSessionClient {
- WTF_MAKE_NONCOPYABLE(V8Inspector);
public:
V8Inspector(v8::Isolate*, v8::Local<v8::Context>);
~V8Inspector();
@@ -36,7 +35,6 @@ public:
void dispatchMessageFromFrontend(const String16& message);
private:
- void eventListeners(v8::Local<v8::Value>, V8EventListenerInfoList&) override;
bool callingContextCanAccessContext(v8::Local<v8::Context> calling, v8::Local<v8::Context> target) override;
String16 valueSubtype(v8::Local<v8::Value>) override;
bool formatAccessorsAsProperties(v8::Local<v8::Value>) override;
@@ -54,11 +52,12 @@ private:
void consoleTime(const String16& title) override { }
void consoleTimeEnd(const String16& title) override { }
void consoleTimeStamp(const String16& title) override { }
- v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate*, v8::Local<v8::Context>, v8::Local<v8::Object> creationContext) override
+ v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate*, v8::Local<v8::Context>) override
{
return v8::MaybeLocal<v8::Value>();
}
- void reportMessageToConsole(v8::Local<v8::Context>, MessageType, MessageLevel, const String16& message, const v8::FunctionCallbackInfo<v8::Value>* arguments, unsigned skipArgumentCount, int maxStackSize) override { }
+ void reportMessageToConsole(v8::Local<v8::Context>, MessageType, MessageLevel, const String16& message, const v8::FunctionCallbackInfo<v8::Value>* arguments, unsigned skipArgumentCount) override { }
+ void installAdditionalCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::Object>) override { }
// V8InspectorSessionClient
void startInstrumenting() override { }
@@ -72,8 +71,7 @@ private:
std::unique_ptr<V8Debugger> m_debugger;
std::unique_ptr<V8InspectorSession> m_session;
- std::unique_ptr<protocol::Dispatcher> m_dispatcher;
- std::unique_ptr<protocol::Frontend> m_frontend;
+ String16 m_state;
};
}

Powered by Google App Engine
This is Rietveld 408576698