Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp

Issue 2044343002: DevTools: update V8Inspector to work with the new v8_inspector API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comment addressed Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/v8_inspector/RemoteObjectId.h" 5 #include "platform/v8_inspector/RemoteObjectId.h"
6 6
7 #include "platform/inspector_protocol/Parser.h" 7 #include "platform/inspector_protocol/Parser.h"
8 #include "platform/inspector_protocol/Platform.h"
8 #include "platform/inspector_protocol/Values.h" 9 #include "platform/inspector_protocol/Values.h"
9 #include "wtf/PtrUtil.h"
10 10
11 namespace blink { 11 namespace blink {
12 12
13 RemoteObjectIdBase::RemoteObjectIdBase() : m_injectedScriptId(0) { } 13 RemoteObjectIdBase::RemoteObjectIdBase() : m_injectedScriptId(0) { }
14 14
15 std::unique_ptr<protocol::DictionaryValue> RemoteObjectIdBase::parseInjectedScri ptId(const String16& objectId) 15 std::unique_ptr<protocol::DictionaryValue> RemoteObjectIdBase::parseInjectedScri ptId(const String16& objectId)
16 { 16 {
17 std::unique_ptr<protocol::Value> parsedValue = protocol::parseJSON(objectId) ; 17 std::unique_ptr<protocol::Value> parsedValue = protocol::parseJSON(objectId) ;
18 if (!parsedValue || parsedValue->type() != protocol::Value::TypeObject) 18 if (!parsedValue || parsedValue->type() != protocol::Value::TypeObject)
19 return nullptr; 19 return nullptr;
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 63
64 return result; 64 return result;
65 } 65 }
66 66
67 String16 RemoteCallFrameId::serialize(int injectedScriptId, int frameOrdinal) 67 String16 RemoteCallFrameId::serialize(int injectedScriptId, int frameOrdinal)
68 { 68 {
69 return "{\"ordinal\":" + String16::number(frameOrdinal) + ",\"injectedScript Id\":" + String16::number(injectedScriptId) + "}"; 69 return "{\"ordinal\":" + String16::number(frameOrdinal) + ",\"injectedScript Id\":" + String16::number(injectedScriptId) + "}";
70 } 70 }
71 71
72 } // namespace blink 72 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698