third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSessionClient.h - Issue 2044343002: DevTools: update V8Inspector to work with the new v8_inspector API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSessionClient.h

Issue 2044343002: DevTools: update V8Inspector to work with the new v8_inspector API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comment addressed Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h ('k') | third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSessionClient.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSessionClient.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSessionClient.h

index fc4998630e118eb13f91c1f7de5b7bbcfcc9e68f..87772b3cca241effb4cea4d7c493f496c17f6b99 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSessionClient.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSessionClient.h

@@ -5,18 +5,17 @@

#ifndef V8InspectorSessionClient_h

#define V8InspectorSessionClient_h

-#include "platform/PlatformExport.h"

#include "platform/inspector_protocol/FrontendChannel.h"

-#include "wtf/Compiler.h"

+#include "platform/inspector_protocol/Platform.h"

#include <v8.h>

namespace blink {

-class PLATFORM_EXPORT V8InspectorSessionClient : WTF_NON_EXPORTED_BASE(public protocol::FrontendChannel)

+class PLATFORM_EXPORT V8InspectorSessionClient

{

public:

- ~V8InspectorSessionClient() override { }

+ virtual ~V8InspectorSessionClient() { }

virtual void startInstrumenting() = 0;

virtual void stopInstrumenting() = 0;

virtual void resumeStartup() = 0;

@@ -27,5 +26,4 @@ public:

} // namespace blink

#endif // V8InspectorSessionClient_h