Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

Issue 2044343002: DevTools: update V8Inspector to work with the new v8_inspector API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comment addressed Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8InspectorSessionImpl_h 5 #ifndef V8InspectorSessionImpl_h
6 #define V8InspectorSessionImpl_h 6 #define V8InspectorSessionImpl_h
7 7
8 #include "platform/inspector_protocol/Allocator.h" 8 #include "platform/inspector_protocol/Allocator.h"
9 #include "platform/inspector_protocol/Collections.h" 9 #include "platform/inspector_protocol/Collections.h"
10 #include "platform/inspector_protocol/DispatcherBase.h" 10 #include "platform/inspector_protocol/DispatcherBase.h"
11 #include "platform/inspector_protocol/Platform.h"
11 #include "platform/inspector_protocol/String16.h" 12 #include "platform/inspector_protocol/String16.h"
12 #include "platform/v8_inspector/protocol/Runtime.h" 13 #include "platform/v8_inspector/protocol/Runtime.h"
13 #include "platform/v8_inspector/public/V8InspectorSession.h" 14 #include "platform/v8_inspector/public/V8InspectorSession.h"
14 #include "platform/v8_inspector/public/V8InspectorSessionClient.h" 15 #include "platform/v8_inspector/public/V8InspectorSessionClient.h"
15 #include "wtf/PtrUtil.h"
16 16
17 #include <v8.h> 17 #include <v8.h>
18 18
19 namespace blink { 19 namespace blink {
20 20
21 class InjectedScript; 21 class InjectedScript;
22 class RemoteObjectIdBase; 22 class RemoteObjectIdBase;
23 class V8DebuggerAgentImpl; 23 class V8DebuggerAgentImpl;
24 class V8DebuggerImpl; 24 class V8DebuggerImpl;
25 class V8HeapProfilerAgentImpl; 25 class V8HeapProfilerAgentImpl;
26 class V8ProfilerAgentImpl; 26 class V8ProfilerAgentImpl;
27 class V8RuntimeAgentImpl; 27 class V8RuntimeAgentImpl;
28 28
29 class V8InspectorSessionImpl : public V8InspectorSession { 29 class V8InspectorSessionImpl : public V8InspectorSession {
30 PROTOCOL_DISALLOW_COPY(V8InspectorSessionImpl); 30 PROTOCOL_DISALLOW_COPY(V8InspectorSessionImpl);
31 public: 31 public:
32 static std::unique_ptr<V8InspectorSessionImpl> create(V8DebuggerImpl*, int c ontextGroupId, V8InspectorSessionClient*, const String16* state); 32 static std::unique_ptr<V8InspectorSessionImpl> create(V8DebuggerImpl*, int c ontextGroupId, protocol::FrontendChannel*, V8InspectorSessionClient*, const Stri ng16* state);
33 ~V8InspectorSessionImpl(); 33 ~V8InspectorSessionImpl();
34 34
35 V8DebuggerImpl* debugger() const { return m_debugger; } 35 V8DebuggerImpl* debugger() const { return m_debugger; }
36 V8InspectorSessionClient* client() const { return m_client; } 36 V8InspectorSessionClient* client() const { return m_client; }
37 V8DebuggerAgentImpl* debuggerAgent() { return m_debuggerAgent.get(); } 37 V8DebuggerAgentImpl* debuggerAgent() { return m_debuggerAgent.get(); }
38 V8ProfilerAgentImpl* profilerAgent() { return m_profilerAgent.get(); } 38 V8ProfilerAgentImpl* profilerAgent() { return m_profilerAgent.get(); }
39 V8RuntimeAgentImpl* runtimeAgent() { return m_runtimeAgent.get(); } 39 V8RuntimeAgentImpl* runtimeAgent() { return m_runtimeAgent.get(); }
40 int contextGroupId() const { return m_contextGroupId; } 40 int contextGroupId() const { return m_contextGroupId; }
41 41
42 InjectedScript* findInjectedScript(ErrorString*, int contextId); 42 InjectedScript* findInjectedScript(ErrorString*, int contextId);
(...skipping 22 matching lines...) Expand all
65 void allAsyncTasksCanceled() override; 65 void allAsyncTasksCanceled() override;
66 void releaseObjectGroup(const String16& objectGroup) override; 66 void releaseObjectGroup(const String16& objectGroup) override;
67 v8::Local<v8::Value> findObject(ErrorString*, const String16& objectId, v8:: Local<v8::Context>* = nullptr, String16* groupName = nullptr) override; 67 v8::Local<v8::Value> findObject(ErrorString*, const String16& objectId, v8:: Local<v8::Context>* = nullptr, String16* groupName = nullptr) override;
68 std::unique_ptr<protocol::Runtime::RemoteObject> wrapObject(v8::Local<v8::Co ntext>, v8::Local<v8::Value>, const String16& groupName, bool generatePreview = false) override; 68 std::unique_ptr<protocol::Runtime::RemoteObject> wrapObject(v8::Local<v8::Co ntext>, v8::Local<v8::Value>, const String16& groupName, bool generatePreview = false) override;
69 std::unique_ptr<protocol::Runtime::RemoteObject> wrapTable(v8::Local<v8::Con text>, v8::Local<v8::Value> table, v8::Local<v8::Value> columns) override; 69 std::unique_ptr<protocol::Runtime::RemoteObject> wrapTable(v8::Local<v8::Con text>, v8::Local<v8::Value> table, v8::Local<v8::Value> columns) override;
70 70
71 V8InspectorSession::Inspectable* inspectedObject(unsigned num); 71 V8InspectorSession::Inspectable* inspectedObject(unsigned num);
72 static const unsigned kInspectedObjectBufferSize = 5; 72 static const unsigned kInspectedObjectBufferSize = 5;
73 73
74 private: 74 private:
75 V8InspectorSessionImpl(V8DebuggerImpl*, int contextGroupId, V8InspectorSessi onClient*, const String16* state); 75 V8InspectorSessionImpl(V8DebuggerImpl*, int contextGroupId, protocol::Fronte ndChannel*, V8InspectorSessionClient*, const String16* state);
76 protocol::DictionaryValue* agentState(const String16& name); 76 protocol::DictionaryValue* agentState(const String16& name);
77 77
78 int m_contextGroupId; 78 int m_contextGroupId;
79 V8DebuggerImpl* m_debugger; 79 V8DebuggerImpl* m_debugger;
80 V8InspectorSessionClient* m_client; 80 V8InspectorSessionClient* m_client;
81 bool m_customObjectFormatterEnabled; 81 bool m_customObjectFormatterEnabled;
82 int m_instrumentationCounter; 82 int m_instrumentationCounter;
83 83
84 protocol::UberDispatcher m_dispatcher; 84 protocol::UberDispatcher m_dispatcher;
85 std::unique_ptr<protocol::DictionaryValue> m_state; 85 std::unique_ptr<protocol::DictionaryValue> m_state;
86 86
87 std::unique_ptr<V8RuntimeAgentImpl> m_runtimeAgent; 87 std::unique_ptr<V8RuntimeAgentImpl> m_runtimeAgent;
88 std::unique_ptr<V8DebuggerAgentImpl> m_debuggerAgent; 88 std::unique_ptr<V8DebuggerAgentImpl> m_debuggerAgent;
89 std::unique_ptr<V8HeapProfilerAgentImpl> m_heapProfilerAgent; 89 std::unique_ptr<V8HeapProfilerAgentImpl> m_heapProfilerAgent;
90 std::unique_ptr<V8ProfilerAgentImpl> m_profilerAgent; 90 std::unique_ptr<V8ProfilerAgentImpl> m_profilerAgent;
91 protocol::Vector<std::unique_ptr<V8InspectorSession::Inspectable>> m_inspect edObjects; 91 protocol::Vector<std::unique_ptr<V8InspectorSession::Inspectable>> m_inspect edObjects;
92 }; 92 };
93 93
94 } // namespace blink 94 } // namespace blink
95 95
96 #endif 96 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698