Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1180)

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template

Issue 2044343002: DevTools: update V8Inspector to work with the new v8_inspector API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comment addressed Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template
diff --git a/third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template b/third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template
index 7d56d1e4bb99a751cbbaddc690cbcbc0556cdeaf..05ca81d3a5714ec58b7e9b6a00e712f5b93364bf 100644
--- a/third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template
+++ b/third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template
@@ -8,7 +8,7 @@
#define protocol_{{domain.domain}}_h
{% if export_macro == "PLATFORM_EXPORT" %}
-#include "platform/PlatformExport.h"
+#include "platform/inspector_protocol/Platform.h"
{% else %}
#include "core/CoreExport.h"
{% endif %}
@@ -19,6 +19,7 @@
#include "platform/inspector_protocol/FrontendChannel.h"
#include "platform/inspector_protocol/Maybe.h"
#include "platform/inspector_protocol/Object.h"
+#include "platform/inspector_protocol/Platform.h"
#include "platform/inspector_protocol/String16.h"
#include "platform/inspector_protocol/Values.h"
#include "platform/inspector_protocol/ValueConversions.h"
@@ -26,9 +27,6 @@
#include "{{output_package}}/{{name}}.h"
{% endfor %}
-#include "wtf/Assertions.h"
-#include "wtf/PtrUtil.h"
-
namespace blink {
namespace protocol {
namespace {{domain.domain}} {
@@ -165,7 +163,14 @@ public:
}
private:
- {{type.id}}() { }
+ {{type.id}}()
+ {
+ {% for property in type.properties %}
+ {% if not(property.optional) and "default_value" in resolve_type(property) %}
+ m_{{property.name}} = {{resolve_type(property).default_value}};
+ {%endif %}
+ {% endfor %}
+ }
{% for property in type.properties %}
{% if property.optional %}

Powered by Google App Engine
This is Rietveld 408576698