Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 202993002: Fix "unreachable code" warnings (MSVC warning 4702) in chrome/browser/. (Closed)

Created:
6 years, 9 months ago by Peter Kasting
Modified:
6 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, vandebo (ex-Chrome), skanuj+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, dcheng, aandrey+blink_chromium.org, extensions-reviews_chromium.org, vsevik, melevin+watch_chromium.org, dominich, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, Greg Billock, fischman+watch_chromium.org, feature-media-reviews_chromium.org, paulirish+reviews_chromium.org, Jered, chrome-apps-syd-reviews_chromium.org, Lei Zhang, tfarina, donnd+watch_chromium.org, mcasas+watch_chromium.org, yurys, tommycli, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, wjia+watch_chromium.org, pfeldman
Visibility:
Public.

Description

Fix "unreachable code" warnings (MSVC warning 4702) in chrome/browser/. BUG=346399 TEST=none R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257797

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -181 lines) Patch
M chrome/browser/chrome_plugin_browsertest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 3 chunks +12 lines, -18 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/browser_action_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/input/input.cc View 7 chunks +14 lines, -11 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/gallery_watch_state_tracker.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/lifetime/application_lifetime_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/notifications/sync_notifier/synced_notification_app_info_service.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/prefs/incognito_mode_prefs.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/process_singleton_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_context_menu/context_menu_content_type.h View 1 chunk +7 lines, -8 lines 0 comments Download
M chrome/browser/renderer_context_menu/context_menu_content_type.cc View 6 chunks +31 lines, -32 lines 0 comments Download
M chrome/browser/renderer_context_menu/context_menu_content_type_panel.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_context_menu/spelling_menu_observer.cc View 3 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller.cc View 2 chunks +29 lines, -50 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/find_bar_host_interactive_uitest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/hung_renderer_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/upgrade_detector_impl.cc View 1 3 chunks +14 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Peter Kasting
https://codereview.chromium.org/202993002/diff/1/chrome/browser/lifetime/application_lifetime_win.cc File chrome/browser/lifetime/application_lifetime_win.cc (right): https://codereview.chromium.org/202993002/diff/1/chrome/browser/lifetime/application_lifetime_win.cc#newcode49 chrome/browser/lifetime/application_lifetime_win.cc:49: NOTREACHED(); (I verified with shrikant that changing this CHECK() ...
6 years, 9 months ago (2014-03-18 02:43:57 UTC) #1
sky
LGTM
6 years, 9 months ago (2014-03-18 15:45:24 UTC) #2
Peter Kasting
6 years, 9 months ago (2014-03-18 22:53:43 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r257797 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698