Fix "unreachable code" warnings (MSVC warning 4702) in chrome/browser/.

chrome/browser/ui/fullscreen/fullscreen_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/fullscreen/fullscreen_controller.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "chrome/browser/app_mode/app_mode_utils.h"
@@ skipping 437 matching lines @@
 void FullscreenController::LostMouseLock() {
   mouse_lock_state_ = MOUSELOCK_NOT_REQUESTED;
   SetMouseLockTab(NULL);
   NotifyMouseLockChange();
   UpdateFullscreenExitBubbleContent();
 }
 
 void FullscreenController::Observe(int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
-  switch (type) {
-    case content::NOTIFICATION_NAV_ENTRY_COMMITTED:
-      if (content::Details<content::LoadCommittedDetails>(details)->
-              is_navigation_to_different_page()) {
-        ExitTabFullscreenOrMouseLockIfNecessary();
-      }
-      break;
-
-    default:
-      NOTREACHED() << "Got a notification we didn't register for.";
-  }
+  DCHECK_EQ(content::NOTIFICATION_NAV_ENTRY_COMMITTED, type);
+  if (content::Details<content::LoadCommittedDetails>(details)->
+      is_navigation_to_different_page())
+    ExitTabFullscreenOrMouseLockIfNecessary();
 }
 
 GURL FullscreenController::GetFullscreenExitBubbleURL() const {
   if (fullscreened_tab_)
     return fullscreened_tab_->GetURL();
-  else if (mouse_lock_tab_)
+  if (mouse_lock_tab_)
     return mouse_lock_tab_->GetURL();
-  else if (!extension_caused_fullscreen_.is_empty())
-    return extension_caused_fullscreen_;
-  else
-    return GURL();
+  return extension_caused_fullscreen_;
 }
 
 FullscreenExitBubbleType FullscreenController::GetFullscreenExitBubbleType()
     const {
   // In kiosk and exclusive app mode we always want to be fullscreen and do not
   // want to show exit instructions for browser mode fullscreen.
   bool app_mode = false;
 #if !defined(OS_MACOSX)  // App mode (kiosk) is not available on Mac yet.
   app_mode = chrome::IsRunningInAppMode();
 #endif
 
-  if (mouse_lock_state_ == MOUSELOCK_ACCEPTED_SILENTLY) {
+  if (mouse_lock_state_ == MOUSELOCK_ACCEPTED_SILENTLY)
+    return FEB_TYPE_NONE;
+
+  if (!fullscreened_tab_) {
+    if (IsMouseLocked())
+      return FEB_TYPE_MOUSELOCK_EXIT_INSTRUCTION;
+    if (IsMouseLockRequested())
+      return FEB_TYPE_MOUSELOCK_BUTTONS;
+    if (!extension_caused_fullscreen_.is_empty())
+      return FEB_TYPE_BROWSER_EXTENSION_FULLSCREEN_EXIT_INSTRUCTION;
+    if (toggled_into_fullscreen_ && !app_mode)
+      return FEB_TYPE_BROWSER_FULLSCREEN_EXIT_INSTRUCTION;
     return FEB_TYPE_NONE;
   }
 
-  if (fullscreened_tab_) {
-    if (tab_fullscreen_accepted_) {
-      if (IsPrivilegedFullscreenForTab()) {
-        return FEB_TYPE_NONE;
-      } else if (IsMouseLocked()) {
-        return FEB_TYPE_FULLSCREEN_MOUSELOCK_EXIT_INSTRUCTION;
-      } else if (IsMouseLockRequested()) {
-        return FEB_TYPE_MOUSELOCK_BUTTONS;
-      } else {
-        return FEB_TYPE_FULLSCREEN_EXIT_INSTRUCTION;
-      }
-    } else {  // Full screen not yet accepted.
-      if (IsMouseLockRequested()) {
-        return FEB_TYPE_FULLSCREEN_MOUSELOCK_BUTTONS;
-      } else {
-        return FEB_TYPE_FULLSCREEN_BUTTONS;
-      }
-    }
-  } else {  // Not tab full screen.
-    if (IsMouseLocked()) {
-      return FEB_TYPE_MOUSELOCK_EXIT_INSTRUCTION;
-    } else if (IsMouseLockRequested()) {
+  if (tab_fullscreen_accepted_) {
+    if (IsPrivilegedFullscreenForTab())
+      return FEB_TYPE_NONE;
+    if (IsMouseLocked())
+      return FEB_TYPE_FULLSCREEN_MOUSELOCK_EXIT_INSTRUCTION;
+    if (IsMouseLockRequested())
       return FEB_TYPE_MOUSELOCK_BUTTONS;
-    } else {
-      if (!extension_caused_fullscreen_.is_empty()) {
-        return FEB_TYPE_BROWSER_EXTENSION_FULLSCREEN_EXIT_INSTRUCTION;
-      } else if (toggled_into_fullscreen_ && !app_mode) {
-        return FEB_TYPE_BROWSER_FULLSCREEN_EXIT_INSTRUCTION;
-      } else {
-        return FEB_TYPE_NONE;
-      }
-    }
+    return FEB_TYPE_FULLSCREEN_EXIT_INSTRUCTION;
   }
-  NOTREACHED();
-  return FEB_TYPE_NONE;
+
+  if (IsMouseLockRequested())
+    return FEB_TYPE_FULLSCREEN_MOUSELOCK_BUTTONS;
+  return FEB_TYPE_FULLSCREEN_BUTTONS;
 }
 
 void FullscreenController::UpdateNotificationRegistrations() {
   if (fullscreened_tab_ && mouse_lock_tab_)
     DCHECK(fullscreened_tab_ == mouse_lock_tab_);
 
   WebContents* tab = fullscreened_tab_ ? fullscreened_tab_ : mouse_lock_tab_;
 
   if (tab && registrar_.IsEmpty()) {
     registrar_.Add(this, content::NOTIFICATION_NAV_ENTRY_COMMITTED,
@@ skipping 250 matching lines @@
       (fullscreened_tab_ == mouse_lock_tab_ && IsPrivilegedFullscreenForTab()) ?
       mouse_lock_tab_->GetFullscreenRenderWidgetHostView() : NULL;
   if (!mouse_lock_view) {
     RenderViewHost* const rvh = mouse_lock_tab_->GetRenderViewHost();
     if (rvh)
       mouse_lock_view = rvh->GetView();
   }
   if (mouse_lock_view)
     mouse_lock_view->UnlockMouse();
 }