Fix "unreachable code" warnings (MSVC warning 4702) in chrome/browser/.

chrome/browser/lifetime/application_lifetime_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/lifetime/application_lifetime.h"
 
 #include "base/bind.h"
 #include "base/prefs/pref_service.h"
 #include "base/win/metro.h"
 #include "base/win/windows_version.h"
@@ skipping 28 matching lines @@
 // mode or some functionality is not available in either mode and we ask user
 // to switch mode.
 // Here mode refers to Windows 8 modes such as Metro (also called immersive)
 // and desktop mode (Classic or traditional).
 
 // Mode switch based on current mode which is devised from current process.
 void AttemptRestartWithModeSwitch() {
 #if defined(USE_AURA)
   // This function should be called only from non aura code path.
   // In aura/ash windows world browser process is always non metro.
-  CHECK(false);
-  return;
-#endif
+  NOTREACHED();

[Peter Kasting, 2014/03/18 02:43:58]

(I verified with shrikant that changing this CHECK() to a NOTREACHED() was a
correct change to make.)

+#else
   // The kRestartSwitchMode preference does not exists for Windows 7 and older
   // operating systems so there is no need for OS version check.
   PrefService* prefs = g_browser_process->local_state();
   if (base::win::IsMetroProcess()) {
     prefs->SetString(prefs::kRelaunchMode,
                      upgrade_util::kRelaunchModeDesktop);
   } else {
     prefs->SetString(prefs::kRelaunchMode,
                      upgrade_util::kRelaunchModeMetro);
   }
   AttemptRestart();
+#endif
 }
 
 #if defined(USE_AURA)
 void ActivateDesktopHelper(AshExecutionStatus ash_execution_status) {
   scoped_ptr<base::Environment> env(base::Environment::Create());
   std::string version_str;
 
   // Get the version variable and remove it from the environment.
   if (!env->GetVar(chrome::kChromeVersionEnvVar, &version_str))
     version_str.clear();
@@ skipping 28 matching lines @@
 }
 
 void AttemptRestartToMetroMode() {
   PrefService* prefs = g_browser_process->local_state();
   prefs->SetString(prefs::kRelaunchMode,
                    upgrade_util::kRelaunchModeMetro);
   AttemptRestart();
 }
 
 }  // namespace chrome