chrome/browser/renderer_context_menu/spelling_menu_observer.cc - Issue 202993002: Fix "unreachable code" warnings (MSVC warning 4702) in chrome/browser/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_context_menu/spelling_menu_observer.cc

Issue 202993002: Fix "unreachable code" warnings (MSVC warning 4702) in chrome/browser/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_context_menu/context_menu_content_type_panel.cc ('k') | chrome/browser/ui/app_list/app_list_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_context_menu/spelling_menu_observer.cc

===================================================================

--- chrome/browser/renderer_context_menu/spelling_menu_observer.cc (revision 256983)

+++ chrome/browser/renderer_context_menu/spelling_menu_observer.cc (working copy)

@@ -201,7 +201,6 @@

default:

return false;

}

- return false;

}

bool SpellingMenuObserver::IsCommandIdChecked(int command_id) {

@@ -210,7 +209,7 @@

if (command_id == IDC_CONTENT_CONTEXT_SPELLING_TOGGLE)

return integrate_spelling_service_.GetValue() &&

!proxy_->GetProfile()->IsOffTheRecord();

- else if (command_id == IDC_CONTENT_CONTEXT_AUTOCORRECT_SPELLING_TOGGLE)

+ if (command_id == IDC_CONTENT_CONTEXT_AUTOCORRECT_SPELLING_TOGGLE)

return autocorrect_spelling_.GetValue() &&

!proxy_->GetProfile()->IsOffTheRecord();

return false;

@@ -244,7 +243,6 @@

default:

return false;

}

- return false;

}

void SpellingMenuObserver::ExecuteCommand(int command_id) {