Fix "unreachable code" warnings (MSVC warning 4702) in chrome/browser/.

chrome/browser/devtools/devtools_sanity_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/cancelable_callback.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/memory/ref_counted.h"
 #include "base/path_service.h"
@@ skipping 76 matching lines @@
   // At first check that JavaScript part of the front-end is loaded by
   // checking that global variable uiTests exists(it's created after all js
   // files have been loaded) and has runTest method.
   ASSERT_TRUE(
       content::ExecuteScriptAndExtractString(
           window->GetRenderViewHost(),
           "window.domAutomationController.send("
           "    '' + (window.uiTests && (typeof uiTests.runTest)));",
           &result));
 
-  if (result == "function") {
-    ASSERT_TRUE(
-        content::ExecuteScriptAndExtractString(
-            window->GetRenderViewHost(),
-            base::StringPrintf("uiTests.runTest('%s')", test_name),
-            &result));
-    EXPECT_EQ("[OK]", result);
-  } else {
-    FAIL() << "DevTools front-end is broken.";
-  }
+  ASSERT_EQ("function", result) << "DevTools front-end is broken.";
+  ASSERT_TRUE(content::ExecuteScriptAndExtractString(
+      window->GetRenderViewHost(),
+      base::StringPrintf("uiTests.runTest('%s')", test_name),
+      &result));
+  EXPECT_EQ("[OK]", result);
 }
 
 }  // namespace
 
 class DevToolsSanityTest : public InProcessBrowserTest {
  public:
   DevToolsSanityTest()
       : window_(NULL),
         inspected_rvh_(NULL) {}
 
@@ skipping 199 matching lines @@
     return native_dialog;
   }
 };
 
 class DevToolsUnresponsiveBeforeUnloadTest: public DevToolsBeforeUnloadTest {
  public:
   virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {}
 };
 
 void TimeoutCallback(const std::string& timeout_message) {
-  FAIL() << timeout_message;
+  ADD_FAILURE() << timeout_message;
   base::MessageLoop::current()->Quit();
 }
 
 // Base class for DevTools tests that test devtools functionality for
 // extensions and content scripts.
 class DevToolsExtensionTest : public DevToolsSanityTest,
                               public content::NotificationObserver {
  public:
   DevToolsExtensionTest() : DevToolsSanityTest() {
     PathService::Get(chrome::DIR_TEST_DATA, &test_extensions_dir_);
@@ skipping 152 matching lines @@
     GURL url = test_server()->GetURL(test_page);
     ui_test_utils::NavigateToURL(browser(), url);
 
     scoped_refptr<WorkerData> worker_data = WaitForFirstSharedWorker();
     OpenDevToolsWindowForSharedWorker(worker_data.get());
     RunTestFunction(window_, test_name);
     CloseDevToolsWindow();
   }
 
   static void TerminateWorkerOnIOThread(scoped_refptr<WorkerData> worker_data) {
-    if (WorkerService::GetInstance()->TerminateWorker(
-            worker_data->worker_process_id, worker_data->worker_route_id)) {
-      WorkerService::GetInstance()->AddObserver(
-          new WorkerTerminationObserver(worker_data.get()));
-      return;
-    }
-    FAIL() << "Failed to terminate worker.\n";
+    if (!WorkerService::GetInstance()->TerminateWorker(
+        worker_data->worker_process_id, worker_data->worker_route_id))
+      FAIL() << "Failed to terminate worker.\n";
+    WorkerService::GetInstance()->AddObserver(
+        new WorkerTerminationObserver(worker_data.get()));
   }
 
   static void TerminateWorker(scoped_refptr<WorkerData> worker_data) {
     BrowserThread::PostTask(
         BrowserThread::IO, FROM_HERE,
         base::Bind(&TerminateWorkerOnIOThread, worker_data));
     content::RunMessageLoop();
   }
 
   static void WaitForFirstSharedWorkerOnIOThread(
@@ skipping 461 matching lines @@
 
 IN_PROC_BROWSER_TEST_F(RemoteDebuggingTest, RemoteDebugger) {
 #if defined(OS_WIN) && defined(USE_ASH)
   // Disable this test in Metro+Ash for now (http://crbug.com/262796).
   if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kAshBrowserTests))
     return;
 #endif
 
   ASSERT_TRUE(RunExtensionTest("target_list")) << message_;
 }