Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: chrome/browser/chrome_plugin_browsertest.cc

Issue 202993002: Fix "unreachable code" warnings (MSVC warning 4702) in chrome/browser/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/devtools/devtools_sanity_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_plugin_browsertest.cc
===================================================================
--- chrome/browser/chrome_plugin_browsertest.cc (revision 256983)
+++ chrome/browser/chrome_plugin_browsertest.cc (working copy)
@@ -246,11 +246,9 @@
EnsureFlashProcessCount(1);
}
+#if defined(OFFICIAL_BUILD)
// Verify that the official builds have the known set of plugins.
IN_PROC_BROWSER_TEST_F(ChromePluginTest, InstalledPlugins) {
-#if !defined(OFFICIAL_BUILD)
- return;
-#endif
const char* expected[] = {
"Chrome PDF Viewer",
"Shockwave Flash",
@@ -273,6 +271,7 @@
ASSERT_TRUE(j != plugins.size()) << "Didn't find " << expected[i];
}
}
+#endif
#if defined(OS_WIN)
@@ -286,7 +285,7 @@
return FALSE;
}
-}
+} // namespace
// Test that if a background tab loads an NPAPI plugin, they are displayed after
// switching to that page. http://crbug.com/335900
« no previous file with comments | « no previous file | chrome/browser/devtools/devtools_sanity_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698