chrome/browser/ui/search/search_tab_helper.cc - Issue 202993002: Fix "unreachable code" warnings (MSVC warning 4702) in chrome/browser/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search/search_tab_helper.cc

Issue 202993002: Fix "unreachable code" warnings (MSVC warning 4702) in chrome/browser/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/fullscreen/fullscreen_controller.cc ('k') | chrome/browser/ui/views/find_bar_host_interactive_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/search/search_tab_helper.cc

===================================================================

--- chrome/browser/ui/search/search_tab_helper.cc (revision 256983)

+++ chrome/browser/ui/search/search_tab_helper.cc (working copy)

@@ -142,15 +142,15 @@

// Returns the OmniboxView for |contents| or NULL if not available.

OmniboxView* GetOmniboxView(content::WebContents* contents) {

- if (!contents)

+ // iOS and Android don't use the Instant framework.

+#if defined(OS_IOS) || defined(OS_ANDROID)

+ return NULL;

+#else

+ if (contents)

return NULL;

- // iOS and Android don't use the Instant framework.

-#if !defined(OS_IOS) && !defined(OS_ANDROID)

Browser* browser = chrome::FindBrowserWithWebContents(contents);

return browser ? browser->window()->GetLocationBar()->GetOmniboxView() : NULL;

#endif

- return NULL;

}

} // namespace