Move GL one-off initialization code.

Move GL one-off initialization code.

Move GL one-off initialization from //ui/gl to //ui/gl/init. Create a
new class GLInitializer to contain the platform specific initialization
methods and add platform specific implementation in a conditionally
included file per platform. Remove the existing one-off initialization
code in GLSurface and from platform specific GLSurface files.

This change is part of step two from the associated bug.

BUG=611142
Committed: https://crrev.com/7cf286c8a63e8f4146d9d63144dfec321a0108b2
Cr-Commit-Position: refs/heads/master@{#397839}

[kylechar, 2016-06-01 14:41:51]

Description was changed from

==========
Move GL one-off initialization code.

Move GL one-off initialization from //ui/gl to //ui/gl/init. Create a
new class GLInitializer to contain the platform specific initialization
components and add a source file per platform. Remove the existing
one-off initialization code in GLSurface.

BUG=601981
==========

to

==========
Move GL one-off initialization code.

Move GL one-off initialization from //ui/gl to //ui/gl/init. Create a
new class GLInitializer to contain the platform specific initialization
methods and add platform specific implementation in a conditionally
included file per platform. Remove the existing one-off initialization
code in GLSurface and from platform specific GLSurface files.

BUG=601981
==========

[kylechar, 2016-06-01 20:48:41]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-01 20:49:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2024953002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2024953002/60001

[commit-bot: I haz the power, 2016-06-01 21:41:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 21:41:03]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[kylechar, 2016-06-02 14:15:10]

Description was changed from

==========
Move GL one-off initialization code.

Move GL one-off initialization from //ui/gl to //ui/gl/init. Create a
new class GLInitializer to contain the platform specific initialization
methods and add platform specific implementation in a conditionally
included file per platform. Remove the existing one-off initialization
code in GLSurface and from platform specific GLSurface files.

BUG=601981
==========

to

==========
Move GL one-off initialization code.

Move GL one-off initialization from //ui/gl to //ui/gl/init. Create a
new class GLInitializer to contain the platform specific initialization
methods and add platform specific implementation in a conditionally
included file per platform. Remove the existing one-off initialization
code in GLSurface and from platform specific GLSurface files.

This change is part of step two from the associated bug.

BUG=611142
==========

[kylechar, 2016-06-02 14:16:36]

kylechar@chromium.org changed reviewers:
+ piman@chromium.org

[kylechar, 2016-06-02 19:28:30]

Description was changed from

==========
Move GL one-off initialization code.

Move GL one-off initialization from //ui/gl to //ui/gl/init. Create a
new class GLInitializer to contain the platform specific initialization
methods and add platform specific implementation in a conditionally
included file per platform. Remove the existing one-off initialization
code in GLSurface and from platform specific GLSurface files.

This change is part of step two from the associated bug.

BUG=611142
==========

to

==========
Move GL one-off initialization code.

Move GL one-off initialization from //ui/gl to //ui/gl/init. Create a
new class GLInitializer to contain the platform specific initialization
methods and add platform specific implementation in a conditionally
included file per platform. Remove the existing one-off initialization
code in GLSurface and from platform specific GLSurface files.

This change is part of step two from the associated bug.

BUG=611142
==========

[piman, 2016-06-03 00:47:05]

https://codereview.chromium.org/2024953002/diff/80001/ui/gl/init/gl_initializ...
File ui/gl/init/gl_initializer.h (right):

https://codereview.chromium.org/2024953002/diff/80001/ui/gl/init/gl_initializ...
ui/gl/init/gl_initializer.h:18: class GL_INIT_EXPORT GLInitializer {
nit: is a class needed at all? If it only has static functions a namespace is
preferred (per style), but then again gl::init is already that.

If the matter is to leave InitializeOneOffPlatform private, maybe we can just
move it to a ui/gl/init/gl_initializer_internal.h or something

[kylechar, 2016-06-03 13:41:21]

https://codereview.chromium.org/2024953002/diff/80001/ui/gl/init/gl_initializ...
File ui/gl/init/gl_initializer.h (right):

https://codereview.chromium.org/2024953002/diff/80001/ui/gl/init/gl_initializ...
ui/gl/init/gl_initializer.h:18: class GL_INIT_EXPORT GLInitializer {
On 2016/06/03 00:47:05, piman OOO back 2016-6-2 wrote:
> nit: is a class needed at all? If it only has static functions a namespace is
> preferred (per style), but then again gl::init is already that.
> 
> If the matter is to leave InitializeOneOffPlatform private, maybe we can just
> move it to a ui/gl/init/gl_initializer_internal.h or something

Yep, it was just to hide InitializeOneOffPlatform but, that's probably a bit too
Java-y. I've removed the class and moved the code for InitializeGLOneOff() and
InitializeGLOneOffImplementation() to gl_factory instead. I've also made it such
that gl_initializer.h is a private header, so code outside the //ui/gl/init
target can't include it.

[piman, 2016-06-03 19:57:16]

Excellent. Thanks and LGTM.

[kylechar, 2016-06-03 20:23:00]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2016-06-03 20:23:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2024953002/100001

[commit-bot: I haz the power, 2016-06-03 23:27:53]

Description was changed from

==========
Move GL one-off initialization code.

Move GL one-off initialization from //ui/gl to //ui/gl/init. Create a
new class GLInitializer to contain the platform specific initialization
methods and add platform specific implementation in a conditionally
included file per platform. Remove the existing one-off initialization
code in GLSurface and from platform specific GLSurface files.

This change is part of step two from the associated bug.

BUG=611142
==========

to

==========
Move GL one-off initialization code.

Move GL one-off initialization from //ui/gl to //ui/gl/init. Create a
new class GLInitializer to contain the platform specific initialization
methods and add platform specific implementation in a conditionally
included file per platform. Remove the existing one-off initialization
code in GLSurface and from platform specific GLSurface files.

This change is part of step two from the associated bug.

BUG=611142
==========

[commit-bot: I haz the power, 2016-06-03 23:27:54]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-03 23:29:49]

Description was changed from

==========
Move GL one-off initialization code.

Move GL one-off initialization from //ui/gl to //ui/gl/init. Create a
new class GLInitializer to contain the platform specific initialization
methods and add platform specific implementation in a conditionally
included file per platform. Remove the existing one-off initialization
code in GLSurface and from platform specific GLSurface files.

This change is part of step two from the associated bug.

BUG=611142
==========

to

==========
Move GL one-off initialization code.

Move GL one-off initialization from //ui/gl to //ui/gl/init. Create a
new class GLInitializer to contain the platform specific initialization
methods and add platform specific implementation in a conditionally
included file per platform. Remove the existing one-off initialization
code in GLSurface and from platform specific GLSurface files.

This change is part of step two from the associated bug.

BUG=611142

Committed: https://crrev.com/7cf286c8a63e8f4146d9d63144dfec321a0108b2
Cr-Commit-Position: refs/heads/master@{#397839}
==========

[commit-bot: I haz the power, 2016-06-03 23:29:50]

Patchset 6 (id:??) landed as
https://crrev.com/7cf286c8a63e8f4146d9d63144dfec321a0108b2
Cr-Commit-Position: refs/heads/master@{#397839}